Retrieving Data to dataset from DB after for loop

Question

0.00/5 (No votes)

See more:

Hi everyone,
I've a query to which i need to pass the id in loop,(i.e., for(int i=0;i<45;i++)
after every iteration i need that retrieved data in dataSet. so that i can view that all data after the loop.
ex:

C#

for (int i = 0; i < 45; i++)
{
    string str = " SELECT * from Table1 where id='"+i+"'";


    SqlCommandcmd = new SqlCommand(str, conn);

    SqlDataAdapter adp = new SqlDataAdapter(cmd);

    DataTable dt = new DataTable();
    adp.Fill(dt);

    gridview1.DataSource = dt;
    gridview1.DataBind();
}

Posted 19-Nov-14 3:20am

sumangta

Updated 19-Nov-14 3:26am

PIEBALDconsult

v2

Add a Solution

Comments

Richard Deeming 19-Nov-14 11:01am

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Although this particular case isn't vulnerable to SQL Injection[^], as you're passing an int, you should still get into the habit of using parameterized queries for everything.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

PIEBALDconsult · Answer 1 · 2014-11-19T03:32:00

Solution 1

Doing it that way will get you only one ID at a time.

If you are using SQL Server, you can use a Table-Valued Parameter.
Use your for loop to fill a DataTable with the IDs, then pass them as a parameter to the query.

SQL Server 2008 User Defined Table Types and Table-Valued Parameters[^]

Posted 19-Nov-14 3:32am

PIEBALDconsult

Comments

sumangta 19-Nov-14 9:56am

okay... thanks for the suggestion.
and by the end i need those values for every ID which i passed individually
to be filled in Dataset (i.e all the entries for every ID's)
is it possible.

Dusara Maulik · Answer 2 · 2014-11-19T03:48:00

You can achieve this with single call of database. Review below block of code. I make two small change and this will give proper result with less time.

C#

string strIds = string.Empty;

for (int i = 0; i &lt; 45; i++)
{
	strIds = strIds == string.Empty ? "'" + i.ToString() + "'" : (",'" + i.ToString() + "'");
}

string str = " SELECT * from Table1 where id IN (" + strIds + ")";

SqlCommandcmd = new SqlCommand(str, conn);

SqlDataAdapter adp = new SqlDataAdapter(cmd);

DataTable dt = new DataTable();
adp.Fill(dt);

gridview1.DataSource = dt;
gridview1.DataBind();