How to remove commas for calculation in C#

Question

1.00/5 (1 vote)

See more:

I have a web form that has a textbox that is formatted using a string code.

C#

TextBoxTHUG.Text = string.Format("{0:0,0}", double.Parse(TextBoxTHUG.Text));

This code turns 1234567 into 1,234,567. I also have a textbox text change code to do calculations for this textbox.

C#

protected void TextBoxTHUG_TextChanged(object sender, EventArgs e)
    {
        int i = Convert.ToInt32(TextBoxTHUG.Text);
        int j = 12;
        TextBoxTHUGDR.Text = Convert.ToString(i / j);
        TextBoxTHG.Focus();
    }

I am trying to get it to calculate put get this error "Input string was not in a correct format". Is there a way to keep the format and calculate or do I have to remove the format and then calculate?

Posted 7-Oct-14 4:22am

Computer Wiz99

Add a Solution

4 solutions

Solution 1

Hi,

Check for value is not blank.

if(TextBoxTHUG.Text!="")
{
....
}

Regards,
Jatinath Jadhav

Posted 7-Oct-14 4:51am

Jatinath

Comments

Maciej Los 7-Oct-14 11:22am

The problem is that the numbers are formated with custom format. The only way to solve it is to use TryParse method. Please, see my answer.
BTW: i voted 2...

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2014-10-07T05:15:00

Solution 2

You can't calculate strings. You need to convert it to numbers.
Try Int32.TryParse[^] method.

Example:

C#

String sNumber = "123,456,789";
int iDenominator = 12;
NumberStyles numStyle = NumberStyles.AllowThousands ;
CultureInfo culture = new CultureInfo("en-US");
int retValue = 0;

bool resultOfConversion = Int32.TryParse(sNumber, numStyle, culture, out retValue);

if (resultOfConversion == true)
    retValue = (int)retValue / iDenominator;


Console.WriteLine("Result: {0}", retValue );
Console.ReadKey();

Note: works perfect ;)

Posted 7-Oct-14 5:15am

Maciej Los

Updated 7-Oct-14 8:21am

v3

Comments

Computer Wiz99 7-Oct-14 11:20am

Maciej Los, thanks for the link. Can you show me how this would work in my code?

Maciej Los 7-Oct-14 11:25am

You mean, you want to write code for you. I can do that, but you'll never learn. Try to solve it yourself, OK?

Computer Wiz99 7-Oct-14 11:30am

I just wanted to see where the Int32TryParse will go. Plus, is there a way for the format to be entered after the calculations?

Maciej Los 7-Oct-14 11:31am

Follow the link, there is an example.
Yes, it is. You need to convert it to string again ;)

Maciej Los 7-Oct-14 14:28pm

I wan't detailed as i had to, sorry. Please, see updated answer.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 13:56pm

Maciej I think int.TryParse() can't remove the commas. If you see the official documentation link you have given, there is one example...

TryToParse("16,667"); // and the output is "Attempted conversion of '16,667' failed."

So, easiest solution is to use Trim function - http://msdn.microsoft.com/en-us/library/kxbw3kwc(v=vs.110).aspx

Maciej Los 7-Oct-14 14:07pm

Thank you for your valuable remark, Tadit. If the comma is system thousend separator and proper country settings are used in code, convertion will not failed. I'll try to show an example.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:11pm

Okay Maciej. Sure. Let me know. :)

Maciej Los 7-Oct-14 14:25pm

Check now ;)
In Polish Windows OS comma is used as a decimal point ;)
10,5 (pl-pl) = 10.5 (en-us)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:31pm

Yeah cool. :)

Maciej Los 7-Oct-14 14:43pm

Thank you ;)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 8-Oct-14 2:04am

:)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:23pm

Trim also won't work. I was wrong also. What we need is String.Replace. I have updated my answer. :) My mind is not working at bed time. ;)

Maciej Los 7-Oct-14 14:31pm

Now in Poland is 8:30PM. I'm gonna go to the bed in next 4 hours.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:33pm

It's 12.02 AM here... :P

Maciej Los 7-Oct-14 14:42pm

Wow! Time to go to the bad. Have a sweet dreams ;)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 8-Oct-14 1:56am

Now its morning. Time to work. :P

Maciej Los 8-Oct-14 2:01am

I'm at work now ;)
Have a nice day, my Friend.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 8-Oct-14 1:58am

My 5. :)

Maciej Los 8-Oct-14 2:02am

Thank you, Tadit ;)

Matt T Heffron 7-Oct-14 14:27pm

+5!

Maciej Los 7-Oct-14 14:29pm

Thank you, Matt

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2014-10-07T07:58:00

Solution 3

Easiest solution is to use String.Replace Method[^].

Posted 7-Oct-14 7:58am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Updated 7-Oct-14 8:21am

v2

Comments

George Jonsson 7-Oct-14 14:04pm

Trim only works at the beginning or end, right?

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:06pm

There are different methods. Trim() will do from start and end. TrimStart() will do it from start and TrimEnd() does it from end.

Matt T Heffron 7-Oct-14 14:12pm

Nope. Trim() will remove from either end, TrimStart() from the start, and TrimEnd() from the end.
Remove() or Replace() are the methods to remove from "inside"

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:19pm

Yes, Matt. My bad. Bed time issues !!!

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:21pm

Updated my answer. Thanks. :)

Maciej Los 7-Oct-14 14:27pm

Tadit, why to replace anything, if Int32.TryParse works perfect?

;)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Oct-14 14:32pm

Yeah, but it is one liner. ;) :P

Maciej Los 7-Oct-14 14:45pm

One-line-code doesn't mean that few-line-code is worse than one-line-code.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 8-Oct-14 1:57am

Yeah, correct. Just an alternative. :)

Yours is the best. :thumbsup

George Jonsson · Accepted Answer · 2014-10-07T08:06:00

Solution 4

You can use

C#

int.Parse(TextBoxTHUG.Text.Replace(",", ""));

Posted 7-Oct-14 8:06am

George Jonsson

Comments

Computer Wiz99 8-Oct-14 9:33am

George Jonsson, where will I apply this code? In Textbox_text change?