i have created a lan application which sends small files but files are being corrupted.not whole file is being sended.plz help

Question

0.00/5 (No votes)

See more:

C#

public void sendfile(FileInfo src,NetworkStream ns)
        {
           
            
            
            network = ns;
            this.data = new byte[packetsize];
            fs = new FileStream(src.FullName, FileMode.Open, FileAccess.Read);
            filesize = fs.Length;
            while (sum < filesize)
            {
                if ((filesize - sum) < packetsize)
                {
                    count = fs.Read(data, 0, (int)(filesize - sum));
                    network.Write(data, 0, (int)(filesize - sum));
                }
                else
                {
                    count = fs.Read(data, 0, data.Length);
                    network.Write(data, 0, data.Length);
                }
                fs.Seek(sum, SeekOrigin.Begin);
                sum += count;
            }
            network.Flush();
           
            
        }



 public void receive(string src, NetworkStream ns,long filesz)
        {
            network = ns;

            filesize = filesz;
         
            fs = new FileStream(src, FileMode.Create, FileAccess.Write);

            
            this.data = new byte[packetsize];
            while (sum < filesize)
                {
                    if ((filesize - sum) < packetsize)
                    {
                        count = network.Read(data, 0, (int)(filesize - sum));
                        fs.Write(data, 0, (int)(filesize - sum));
                    }
                    else
                    {
                        count = network.Read(data, 0, data.Length);
                        fs.Write(data, 0, data.Length);
                    }
                    fs.Seek(sum, SeekOrigin.Begin);
                    sum += count;
                }
           
            
            }

Posted 29-Sep-14 5:50am

Member 11118232

Updated 29-Sep-14 6:02am

CHill60

v2

Add a Solution

Comments

Richard MacCutchan 29-Sep-14 13:05pm

You forgot to initialise sum to some value before starting each loop.

Member 11118232 30-Sep-14 0:37am

now i have initialized sum=0 before starting of loops.but still facing same problem..and also i have noticed that everytime i send file than the file received is 8 kb less than orignal file..and 8 kb is size of my packet.so i think last packet is lost somewhere

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2014-09-29T21:17:00

Try the following modifications

C++

public void sendfile(FileInfo src,NetworkStream ns)
{
    network = ns;
    this.data = new byte[packetsize];
    fs = new FileStream(src.FullName, FileMode.Open, FileAccess.Read);
    filesize = fs.Length;
    int sum = 0;
    while (sum < filesize)
    {
        int count = filesize - sum;
        if (count > packetsize)
            count = packetsize;
        count = fs.Read(data, 0, count); // read the bytes
        network.Write(data, 0, count); // write only the number of bytes read
        sum += count;
    }
    network.Flush();
}



public void receive(string src, NetworkStream ns,long filesz)
{
    network = ns;
    
    filesize = filesz;
    
    fs = new FileStream(src, FileMode.Create, FileAccess.Write);
    
    
    this.data = new byte[packetsize];
    int sum = 0;
    while (sum < filesize)
    {
        int count = filesize - sum;
        if (count > packetsize)
            count = packetsize;
        count = network.Read(data, 0, count);
        fs.Write(data, 0, count);
        sum += count;
    }
}