SQL statement problem

Question

1.00/5 (1 vote)

See more:

C#

cmd.CommandText = 
@"INSERT INTO SSS_Contribution 
VALUES (
EmpID = " + txtEmployeeID.Text + @" , 
LastName = '" + txtEmployeeLastName.Text + @"', 
FirstName = '" + txtEmployeeFirstName.Text + @"', 
MiddleName = '" + txtEmployeeMiddleName.Text + @"', 
SSS = '" + txtSSSNo.Text + @"', 
Client = '" + txtClient.Text + @"', 
DeptCoor = '" + txtCoordinator.Text + @"', 
FirstERShare = '0.00', 
FirstEEShare = '0.00', 
FirstTotal = '0.00', 
SecondERShare = " + y.ToString() + @", 
SecondEEShare = " + txtSSS.Text + @", 
SecondTotal = (" + txtSSS.Text + " + " + y.ToString() + @"), 
TotalERShare = (" + y.ToString() + @"), 
TotalEEShare = (" + txtSSS.Text + @"), 
TotalContribution = (" + txtSSS.Text + " + " + y.ToString() + @")
)";

Whats wrong in my sql statement? It keeps having this error

Incorrect syntax near '='.

I tried debugging it many times. Thank you kind sirs :)

Posted 16-Sep-14 21:38pm

BeastMode10

Updated 16-Sep-14 22:25pm

George Jonsson

v3

Add a Solution

Comments

Thomas Nielsen - getCore 17-Sep-14 4:20am

make a stored procedure instead!
If you must do this, use string.format method instead to clarify your syntax and/ or put the sql statement into a variable before assigning to cammand text, then place a breakpoint and copy paste to your MSSQL management studio or whateer rdbms client you have and try to execute to get more help on the problem if it isn't already clear

George Jonsson 17-Sep-14 4:24am

You should post the resulting string as well.

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2014-09-16T21:46:00

Your approach is wrong from the very beginning. You should never create a query by concatenation of string taken from your UI. Instead, you need to use parametrized statements. Please see: http://msdn.microsoft.com/en-us/library/ff648339.aspx[^].

If you do it your way, you make your application totally vulnerable to a well-known exploit: SQL Injection. The user can write anything in the UI, including some SQL fragment. Are you getting the idea? This is how: http://xkcd.com/327[^].

Please see my past answers:
EROR IN UPATE in com.ExecuteNonQuery();[^],
hi name is not displaying in name?[^].

—SA

_Asif_ · Answer 2 · 2014-09-16T22:46:00

Solution 4

Your INSERT query syntax is wrong. The syntax is

SQL

INSERT INTO <table_name> [(<ColumnName1, ColumnName2, ... ColumnNameN>)] VALUES (Data1, Data2... DataN);

Apart from that you need to use Parameterized SQL as explained by Sergey.

Posted 16-Sep-14 22:46pm

_Asif_

Updated 17-Sep-14 23:43pm

v2

Kan07 · Answer 3 · 2014-09-16T22:08:00

SQL

cmd.CommandText = "INSERT INTO SSS_Contribution VALUES (" + txtEmployeeID.Text + " ,'" + txtEmployeeLastName.Text + "','" + txtEmployeeFirstName.Text + "','" + txtEmployeeMiddleName.Text + "',  '" + txtSSSNo.Text + "',  '" + txtClient.Text + "','" + txtCoordinator.Text + "', '0.00', '0.00',  '0.00',  " + y.ToString() + ", " + txtSSS.Text + ",(" + txtSSS.Text + " + " + y.ToString() + "), (" + y.ToString() +"), (" + txtSSS.Text + "), (" + txtSSS.Text + " + " + y.ToString() + "))";

* store concatenated section (i marked - underlined : to string and insert )

Kim Togo · Answer 4 · 2014-09-16T22:24:00

As Sergey has written. Do not concat SQL statements in a string and use user input directly.

A simple description that is easy to understand can be found here: Give me parameterized SQL, or give me death/[^]

A simple user input in "txtEmployeeLastName.Text" like => Hello 'World
will make the SQL statement fail.

SQL statement problem

4 solutions

Solution 1

Solution 4

Solution 2

Solution 3

Add your solution here

Preview 0