Javascript: Image change not working

Question

1.00/5 (1 vote)

See more:

The code doesn't show any image. Please help.

HTML

<!DOCTYPE html>
<html>
<body>

<script type="text/javascript">

var myVar = setInterval(function(){randim()},1000);

function randim(){
var bannerImages = new Array( );
bannerImages[0] = "1.jpg";
bannerImages[1] = "2.jpg";
bannerImages[2] = "3.jpg";
bannerImages[3] = "4.jpg";
bannerImages[4] = "5.jpg";
bannerImages[5] = "6.jpg";
bannerImages[6] = "7.jpg";
var randomImageIndex = 0;
randomImageIndex = Math.round( Math.random( ) * 6 );
}
function myStopFunction()
{
clearInterval(myVar);
}

</script>

<p>A script on this page starts this image change:</p>
<img src="\""+bannerImages[randomImageIndex]+"\"">
<button  onclick="myStopFunction()">Stop image</button>
</body>
</html>

Posted 15-Mar-14 8:47am

Madhukar Krishna

Updated 16-Mar-14 19:10pm

VICK

v3

Add a Solution

Comments

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 15-Mar-14 14:51pm

What errors you see on Developer Tool's Console window?

Sergey Alexandrovich Kryukov 15-Mar-14 21:57pm

No matter what it does, 7 statements like ... = "1.jpg" means that you are doing not programming, but something opposite, defeating the whole idea of programming and its purpose.
—SA

2 solutions

Solution 2

Thanks Mahesh . Your solution works:-

XML

<!DOCTYPE html>
<html>
<body>

<script type="text/javascript">

var myVar = setInterval(function(){randim()},1000);

function randim(){
var bannerImages = new Array( );
bannerImages[0] = "1.jpg";
bannerImages[1] = "2.jpg";
bannerImages[2] = "3.jpg";
bannerImages[3] = "4.jpg";
bannerImages[4] = "5.jpg";
bannerImages[5] = "6.jpg";
bannerImages[6] = "7.jpg";
var randomImageIndex = 0;
randomImageIndex = Math.round( Math.random( ) * 8 );

var img1 = document.getElementById("demo");

img1.src = bannerImages[randomImageIndex];

}

function myStopFunction()
{
clearInterval(myVar);
}


</script>

<p>A script on this page starts this image change:</p>
<img id="demo" src="i.jpg" />
<button onclick="myStopFunction()">Stop image</button>



</body>
</html>

Posted 15-Mar-14 23:21pm

Madhukar Krishna

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mahesh_Bhosale · Accepted Answer · 2014-03-15T11:06:00

XML

<style type="text/javascript">
var images = new Array('image1.jpg', 'image2.jpg', 'etc');
function ChangeLogo()
{
  var i = document.getElementById('theImg');
  // randomly pick image from array
  i.src = images[Math.floor(Math.random()*i.length)];
  setTimeout("ChangeLogo()", 8000); // Change logo every 8 seconds
}
window.onload = ChangeLogo; // Start change once page loaded
</script>

See this http://www.brothercake.com/site/resources/scripts/transitions/[^] site for some code for doing image transitions.