index was out of range. must be nonnegative and less than the size of the collection in c#

Question

0.00/5 (No votes)

See more:

I'm getting this error index was out of range. must be nonnegative and less than the size of the collection in c#
parameter: index

Can anyone help me with this?

C#

private static string GetTxtBtwn(string input, string start, string end, int startIndex, bool UseLastIndexOf)
        {
            int index1 = UseLastIndexOf ? input.LastIndexOf(start, startIndex) :
                                          input.IndexOf(start, startIndex);
            if (index1 == -1) return "";
            index1 += start.Length;
            int index2 = input.IndexOf(end, index1);
            if (index2 == -1) return input.Substring(index1);
            return input.Substring(index1, index2 - index1);

            
        }

Posted 15-Mar-14 0:13am

Member 10668188

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2014-03-15T00:38:00

Exactly why is up to your data, but the mechanics of getting the problem are simple:
What happens if the end is found before the start, or as part of the start string?
I.e. if input is "1234567890" and start is "345678" and end is "23", then

index1 == 8
index2 == 1

So your length will be negative. That won't cause the exact error you are getting this time, but it's an example of a "route to failure" which depends on your data to work out exactly what the problem is.

If you get a problem like this, use the debugger, and look at your data. Step through line by line and try to spot what values are what.

Serge Desmedt · Answer 2 · 2014-03-15T02:56:00

Allthough I do not agree with the analysis of OriginalGriff, you are starting your search for the second substring after the end of the first string so his assertion should not happen, i do agree with his statement: depends on your data so use the debugger.

Are you sure the parameter startindex you are providing to the method is not past the end of the string? That would throw this error at the line looking for your index1.

index was out of range. must be nonnegative and less than the size of the collection in c#

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0