Stored Procedure error in sql server

Question

1.00/5 (1 vote)

See more:

SQL

CREATE PROCEDURE [SP_PersonelInfo]
	@[personelcode] varchar (20),
	@[firstname] nvarchar(50),
	@[lastname) nvarchar(50),
	@[FK_pID] int,
	@[employmenttype] nvarchar(50),
	@[employmentdate] char(10)
begin
	insert into PersonelInfo(PersonelCode,FirstName,LastName)
	Values([personelcode],[firstname],[lastname])
DECLARE @lstprsnlID INT
set @lstprsnlID = SCOPE_IDENTITY();

	insert into EmploymentInfo(FK_pID,EmploymentType,EmploymentDate)
        Values([lstprsnlID],[employmenttype],[employmentdate])
END
go

the error is on this part:varchar (20)
and the error text is: "Incorrect syntax near '20'. Expecting SELECT, or '('"

and you can see error picture here:
<a href="http://i44.tinypic.com/v5a79d.png">error</a>

Posted 26-Jan-14 20:43pm

mit62

Updated 26-Jan-14 21:17pm

v5

Add a Solution

Comments

thatraja 27-Jan-14 2:45am

Include the error message in your question

thatraja 27-Jan-14 2:56am

Some URLs not working(blocked) for some of us. That's why I'm asking the error message in text.

Or use hosts like imgur.com to upload images

OriginalGriff 27-Jan-14 3:05am

No, I'm not going to go to an unknown site, and download an unknown file, from a total stranger.
Why would I? Does an error message need a picture? No - it's just you are too lazy to copy and paste...
If you want help, then make it as simple as possible for us to give that help: edit your question and include the error message.
Help us to help you!

Use the "Improve question" widget to edit your question and provide better information.

Member 10454499 27-Jan-14 7:20am

Why don't you use varchar instead of nvarchar, its save memory

OriginalGriff 27-Jan-14 8:29am

Unicode, probably.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

VeeraAnnapureddy · Accepted Answer · 2014-01-26T21:11:00

CREATE PROCEDURE [SP_PersonelInfo](
	@personelcode varchar(20),
	@firstname nvarchar(50),
	@lastname nvarchar(50),
	@FK_pID int,
	@employmenttype nvarchar(50),
	@employmentdate char(10))
	as 
	set nocount on
begin
	insert into PersonelInfo(PersonelCode,FirstName,LastName)
	Values(@personelcode,@firstname,@lastname)
DECLARE @lstprsnlID INT
set @lstprsnlID = SCOPE_IDENTITY();
 
	insert into PersonelInfo(FK_pID,EmploymentType,EmploymentDate)
        Values(@lstprsnlID,@employmenttype,@employmentdate)
END
set nocount off

Kornfeld Eliyahu Peter · Accepted Answer · 2014-01-26T21:14:00

Solution 2

Remove all your brackets!!!

SQL

CREATE PROCEDURE [SP_PersonelInfo]
    @personelcode varchar (20),
    @firstname nvarchar(50),
    @lastname nvarchar(50),
    @FK_pID int,
    @employmenttype nvarchar(50),
    @employmentdate char(10)

Posted 26-Jan-14 21:14pm

Kornfeld Eliyahu Peter

Comments

mit62 27-Jan-14 3:21am

thanks.

aliwpf · Accepted Answer · 2014-01-26T21:17:00

Solution 3

hi.remove bracket from your paramters.

Posted 26-Jan-14 21:17pm

aliwpf