why doesnt this code work?

Question

0.00/5 (No votes)

See more:

C#

if (bool232 = true)
            {
                if (gameTime.TotalGameTime.TotalSeconds >= 3)
                {
                    this.Exit();
                }
            }
            else
            {
            }

For some reason this code is making my game exit after 3 seconds despite "bool232" being false, the only time bool232 is true is when the game over screen is shown
any help?

Posted 10-Dec-13 10:03am

Member 10442210

Add a Solution

3 solutions

Solution 3

As the others pointed out you are assigning true to your variable instead of comparing it.

I also agree that

if (bool232)

is better than

if (bool232 == true)

though if you are going to use the == a good practice (sometimes called yoda code) is to always put the constant first

if (true == bool232)

that way you will always get a compile error if you forget an '=' sign.

Posted 10-Dec-13 10:18am

bowlturner

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Matt T Heffron · Accepted Answer · 2013-12-10T10:06:00

Solution 1

Don't you mean:

C#

if (bool232 == true)

or even better:

C#

if (bool232)

(A better name for that boolean wouldn't hurt, either.)

Posted 10-Dec-13 10:06am

Matt T Heffron

Comments

RaisKazi 10-Dec-13 16:07pm

My 5!

Ron Beyer 10-Dec-13 16:08pm

+5, I've had many a head-scratching session when I started programming about missing that other equals sign. The single equals actually makes bool232 true, then the if evaluates it, so it will always be true in the original code.

Matt T Heffron 10-Dec-13 16:13pm

One of the tricks I recall from my c++ days is always to put the constant first. Only a very dumb compiler will allow: if (true = variable)... It'll tell you right away what you've done wrong.
Of course, for boolean values, just use it. There's no need to compare with true.

Richard C Bishop · Accepted Answer · 2013-12-10T10:07:00

Solution 2

It should read like this:

if (bool232 == true)
{
    if (gameTime.TotalGameTime.TotalSeconds >= 3)
    {
        this.Exit();
    }
}
else
{
}

You are assigning a value inside the if statement instead of comparing. The code should not even compile.

Posted 10-Dec-13 10:07am

Richard C Bishop

Comments

Ron Beyer 10-Dec-13 16:10pm

Actually it will compile, with a warning (a "are you sure you meant to do that" one). If the person ignores warnings, then it will happily run.

Richard C Bishop 10-Dec-13 16:20pm

Ahhh, thank you for the clarification.

CHill60 10-Dec-13 16:46pm

Could see where you were coming from though ... if it had been (e.g.) an int then you *would* get the error "Cannot implicitly convert type 'int' to 'bool'"

Richard C Bishop 10-Dec-13 17:00pm

Indeed, I guess I just remember compiler errors when I attempted this before.