Well, no, that's not a smart way - for a couple of reasons:
Firstly, it'll probably not show any image at all because it sits in a loop changing them and never gets a chance to do the Paint event for anything...
Secondly, because if it did show anything, it would be replaced so quickly that the user probably wouldn't notice it at all...
It's difficult to say exactly what to do, because you don;t specify the environment you are running in, but the use of PictureBox implies WinForms, so I'll go with that:
1) Add a
Timer
to your form, and set it's
Interval
property to 1000 - that's a one second interval. Start the timer.
3) Add a
private bool
field to your form class, call it
showFirst
and set it to
true
2) Handle the
Timer.Tick
event, and do this:
pictureBox1.Image = showFirst ? image1 : image2;
showFirst = !showFirst;
That should change your image every second.