streamreading text file and getting data from lines and set objects properties with data

Question

0.00/5 (No votes)

See more:

I'm streaming text files with stream read, But the code is not working efficiently. for example text file has max. 1000 lines but reading and writing data to db is takes about minutes...
In my project I'm reading text files line by line after that ,I'm adding this lines to a string arrayList. when I finish reading lines, I set lines to an object for writing data to my database.
This is my text reading code block;

List<string> dataList = new List<string>();
using (StreamReader sr = new StreamReader(file))
{
String line;
while ((line = sr.ReadLine()) != null)
{
if (!string.IsNullOrEmpty(line))
dataList.Add(line);
}
}

Can I make my codes faster?
And my codes second part is that takes more time ;

BankObject headerObj = new BankObject();

for (int i = 0; i

Posted 10-Mar-10 23:36pm

rebelasi

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2010-03-10T23:57:00

Since the code you show only appears to use dataList as an array, why not just use

string[] dataList = File.ReadAllLines(file);

instead of your first loop - it will be much faster.

Your second loop is harder to optimize - it depends on what the data actually looks like to an extent. I do notice though that you don't check at all to ensure there is enough room in the string to extract a substring - what happens if the line from the file is 20 characters? It may be worth using a foreach loop rather than the for loop as it would get rid of the array access each time (although the non-debug build would optimize this anyway).

Don't use magic numbers unless you have to - they are a maintenance nightmare!