Incorrect syntax near '-'.

Question

2.00/5 (2 votes)

See more:

m executing sql query but i keep on getting this error "Incorrect syntax near '-'."

this sql is for retriving data of a range date.

here is my sql

SQL

ALTER PROCEDURE [dbo].[viewMaterialByDate]
@fromDate date,
@toDate date
AS
Select MaterialID,Material,Topic  FROM StudyMaterial,Topic
WHERE Topic.TopicID= StudyMaterial.TopicID and 
 [Date] >=@fromDate and [Date] <= @toDate

Posted 26-Aug-13 2:56am

Member 10232726

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Srinivas Kalabarigi · Answer 1 · 2013-08-26T03:10:00

Solution 1

try the below as you might forgot to add braces to the parameters:

SQL

ALTER PROCEDURE [dbo].[viewMaterialByDate]
(@fromDate date,
@toDate date)
AS
Select MaterialID,Material,Topic  FROM StudyMaterial,Topic
WHERE Topic.TopicID= StudyMaterial.TopicID and
 [Date] >=@fromDate and [Date] <= @toDate

Posted 26-Aug-13 3:10am

Srinivas Kalabarigi

Comments

W∴ Balboos, GHB 26-Aug-13 9:16am

I noticed that, too (you and I were posting together). Not knowing the database he was using, I deferred to the ALTER as an indication that CREATE already worked - perhaps his database accepts that syntax as it seems unambiguous,

W∴ Balboos, *GHB* · Answer 2 · 2013-08-26T03:11:00

Since you're at the stage of an ALTER PROCEDURE, I presume the SP is part of the database (odd that you name a SP a view).

That being said, it must be the data entry that is causing the error - do you have a sample of an entry that fails? Have you tried this with hard-coded dates as the range or is this the result of something like a program loop (which would require you looking into your data feed)?

Another thought: why not an INNER JOIN between StudyMaterial and Topic tables since you require a match for all of your query return values?

SaqibRasheed · Answer 3 · 2013-08-26T03:14:00

Solution 4

The issue may be with the date values which you are passing because there is nothing else in your query which may cause an error. Try giving hard-coded values for testing to the same query and then run it; if it works then it is obviously the issue with date parameters.

Posted 26-Aug-13 3:14am

SaqibRasheed