Subtraction of 2 integers stored in arrays

Question

0.00/5 (No votes)

See more:

Hi! I have written a code to subtract 2 large integers stored in arrays! But the problem is, its not working when the minuend is smaller than the subtrahend, i.e, when the answer would be negative. I am taking 2 char arrays as parameters, converting them to int arrays, working with them, storing the result in a char array & returning it! Can somebody please point out the optimizations needed in the code!

C++

#include<iostream.h>
#include<conio.h>
#include<string.h>

class Sub{
 public:
 char *subArray(char a[], char b[])
 {
  int i, j, k, diff[255], borr, size1=0, size2=0, x[255], y[255];
  char temp[255], *p;
  cout<<"\nNuM1: "  ;
  for(i=0; a[i]!=NULL; i++)
  {
    x[i]=a[i]-'0';                 //conversion into int array 
    size1++;                     
    cout<<x[i];
  }
  cout<<"\nNuM2: "  ;
  for(i=0; b[i]!=NULL; i++)
  {
    y[i]=b[i]-'0';                //conversion into int array 
    size2++;
    cout<<y[i];
  }
  if(size1<size2)                
  {
	p=subArray(b, a);
        p[0]=-p[0];               //not printing the correct value
	return p;
  }
  else
  {
	 for(j=0; j<size2; j++)
	 {
	  y[j]=-y[j];
	 }
	 k=borr=0;

	 for(i=size1-1, j=size2-1;i>=0 && j>=0; i--, j--, k++)
	 {
	  diff[k]=x[i]+y[j]-borr;
	 if(diff[k]<0)
	 {
	  diff[k]+=10;
	  borr=1;
	 }
	 else
	 borr=0;
	 }
	 if(i>=0)
	{
	 for(;i>=0;i--,k++)
	 {
	  diff[k]=x[i]-borr;
	  if(diff[k]<0)
	  {
		diff[k]+=10;
		borr=1;
	  }
	  else
	  borr=0;
	}
  }

  i=j=0;
  for(i=k-1; i>=0; i--)
  {
	 if(diff[i]<0)
	 {
	  temp[j++]='-';
	  temp[j++]=-(diff[i])+'0';
	 }
	 else
	 temp[j++]=diff[i]+'0';
  }
  temp[j]='\0';
  return temp;
  }
 }
};
void main()
{
 Sub s;
 char num1[255], num2[255], *diff;
 cout<<"NuM1: ";
 cin>>num1 ;
 cout<<"\nNuM2: ";
 cin>>num2;
 diff = s.subArray(num1, num2);
 cout<<"\nDifference: ";
 while(*diff != NULL)
 {
  cout<<*diff;
  diff++;
 }
}

Posted 14-Aug-13 20:36pm

Titas93

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nv3 · Answer 1 · 2013-08-14T21:20:00

The biggest problem: You are returning a pointer to the temp array that allocated on the stack. Once you return from your function, that array goes out of existence and it is pure luck if the calling function can see anything in that array.

Solution: Allocate the result array by the caller and pass a pointer to that array as parameter to your function:

C++

char diff[255];
...
Sub (res, num1, num2);

There are a couple of things that you have solved a little clumsy. Checking for the length of both arguments is basically useless, because any of them might contain leading zeros.

I would handle the sign of the arguments and the result in a separate variable and that will save you the recursive call to your function.