File to XML storage.. Please Help!

Question

0.00/5 (No votes)

See more:

I am trying to write a File (Binary Data) into an XML file... The code can be seen below:

C#

private void FillFileData(string file)
{
                DataSet xmlFile = new DataSet("File");
    DataTable table;
    table = xmlFile.Tables.Add("Data");
    table.Columns.Add("Name",typeof(string));
    table.Columns.Add("MD5",typeof(string));
    table.Columns.Add("data",typeof(string));
    StreamReader sr = new StreamReader(file);
    table.Rows.Add(Path.GetFileName(file),"x",sr.ReadToEnd());
    sr.Close();
                xmlFile.WriteXML("test.xml");
                xmlFile.Dispose();
}

I would really appreciate any comments since i am really out of ideas here on what type should i add the Column "data" and what should i use to read the data into there...

If by any chance someone can provide info on getting the MD5 as well that would be great.

Posted 1-Mar-10 0:50am

qyte64

Updated 1-Mar-10 0:54am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Alaric Dailey · Accepted Answer · 2010-03-01T05:48:00

well if you want to store binary data, you need to change the type of your column.

your md5 signature should also be changed.

you are missing your schema, so you would have to define your schema before loading your data.

So I fixed all that and rewrote your function for you, including generating the hash.

C#

private string FillFileData(string file)
{
    using (var xmlFile = new DataSet("File"))
    {
        using (var table = xmlFile.Tables.Add("Data"))
        {
            table.Columns.Add("Name", typeof(string));
            table.Columns.Add("MD5", typeof(byte[]));
            table.Columns.Add("data", typeof(byte[]));
            byte[] b = File.ReadAllBytes(file);
            var hasher = System.Security.Cryptography.MD5.Create();
            var outputHash = hasher.ComputeHash(b);
            var fileName = Path.GetFileName(file);
            var oo = new object[] { fileName, outputHash, b };
            table.Rows.Add(oo);
            string outputFileName = Path.GetTempFileName();
            using (var sw = new StreamWriter(outputFileName))
            {
                xmlFile.WriteXmlSchema(sw);
                xmlFile.WriteXml(sw);
            }
            return outputFileName;
        }
    }
}