the ado.net code is not working why?

Question

1.00/5 (1 vote)

See more:

the following code is not working what is wrong with it:

public class Class1
{
    private int _Event;
    private int _EmpId;
    private string _EmpName;
    private int _Salary;
    private string _City;
    private int _Atype;
    private static readonly string _connectionstring;
    public int Event
    {
        get { return _Event; }
        set { _Event = value; }
    }
    public int EmpId
    {
        get { return _EmpId; }
        set { _EmpId = value; }
    }
    public string EmpName
    {
        get { return _EmpName; }
        set { _EmpName = value; }
    }
    public int Salary
    {
        get { return _Salary; }
        set { _Salary = value; }
    }
    public string City
    {
        get { return _City; }
        set { _City = value; }
    }
    public int Atype
    {
        get { return _Atype; }
        set { _Atype = value; }
    }

    string ss = "";
    public void open()
    {
        String constr = ConfigurationManager.ConnectionStrings["testing"].ConnectionString;
        SqlConnection connect = new SqlConnection(constr);
        
    }
         
   	public void save()
	{

        
        SqlCommand command = new SqlCommand("spdatabaseconnect",connect);
        command.CommandType = CommandType.StoredProcedure;
        command.Parameters.Add("@event", SqlDbType.TinyInt).Value = Atype;
        command.Parameters.Add("@EmpId", SqlDbType.Int).Value = EmpId ;
        command.Parameters.Add("@Emp_name", SqlDbType.NVarChar,50).Value = EmpName ;
        command.Parameters.Add("@Salary", SqlDbType.Int).Value = Salary ;
        command.Parameters.Add("@City", SqlDbType.NVarChar,50).Value = City ;
        connect.Open();
        command.ExecuteNonQuery();
        command.Connection.Close();
        command.Dispose(); 
        connect.Close();
       
    }

This my class file code .
The code for button click is :

Class1 obj = new Class1();
    obj.EmpId = Convert.ToInt32(txtEmpId.Text);
     obj.EmpName = txtEmpName.Text;
     obj.Salary = Convert.ToInt32(txtSalary.Text);
     obj.City = txtCity.Text;
     obj.Atype = Convert.ToInt32(txtEvent.Text);
     obj.save();

I want to write the connection string,connection and command object to be in open().
In save method i only want to have parameters . what to do? eg if i want to open a connection when i write object.open() then the code in open method executes.

Posted 12-Jun-13 0:39am

Rambo_Raja

Add a Solution

Comments

Richard MacCutchan 12-Jun-13 6:49am

What do you mean by "not working"; please explain in proper detail.

[no name] 12-Jun-13 6:49am

You SqlConnection is a local variable to your open method and your open method is defined as returning void. You either need to make the connection object a class level variable or return it from the open method.

Member 9956178 12-Jun-13 6:50am

Create a class Connect separetly for Connect
like this
ublic SqlConnection con;
public Connect()
{
con = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnString"].ConnectionString);
}
public void OpenCon()
{
try
{
con.Close();
con.Open();
}
catch (Exception)
{
con.Open();
}

}
public void CloseC()
{
try
{

con.Close();

}
catch (Exception e)
{
con.Close();
}
Then for Save
do using(Sqlconnection con = new Sqlconnection(Connect.getconnectionsource()))
{
// save method is correct
}
Keeping connection class sepate will help you in many ways!
...or if you do not want this..
You need to call Open() before Sqlcommand cmd = new sqlcommand(); statement

Rambo_Raja 12-Jun-13 7:16am

i want to write connection string,connection object,command in a new method named open().means that i dont want to write connection string,command,connection in save method.

[no name] 12-Jun-13 7:30am

Okay so go right ahead and do that. There is absolutely nothing stopping you.

Rambo_Raja 12-Jun-13 8:48am

hey dude are you a very good programmer?If yes than tell me where i m wrong because i m novice.you can downvote my answer nothing bothers me, but please do a favour tell me where am i wrong and what to do? please brother. thanks for your kindness.

[no name] 12-Jun-13 9:24am

No actually I am a terrible programmer. Which is why I spend a great deal of time reading, studying and researching. As for what you have done wrong, you have already been told. What should you do? Well you should get yourself a decent basic book on programming and study it. Learn about variable scope, creating functions and passing parameters would help you a great deal in this particular instance.

Rambo_Raja 12-Jun-13 7:33am

ha ha ..what does that mean?

Rambo_Raja 12-Jun-13 7:39am

hey dude are you a very good programmer?If yes than tell me where i m wrong because i m novice.you can downvote my answer nothing bothers me, but please do a favour tell me where am i wrong and what to do? please brother. thanks for your kindness.

CHill60 12-Jun-13 8:44am

If you don't use the Reply link next to a comment then the poster won't know that you have responded

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Answer 1 · 2013-06-12T02:47:00

Try adding

C#

SqlConnection connect;

at the top of your class or changing your open function to return the SqlConnection

C#

public SqlConnection open()
    {
        String constr = ConfigurationManager.ConnectionStrings["testing"].ConnectionString;
        connect = new SqlConnection(constr);
        return connect;  //choose one or the other of the methods

    }

Yuriy Loginov · Answer 2 · 2013-06-12T03:01:00

you should merge your open() and save() methods.
try this:

C#

public void openAndSave()
    {
        String constr = ConfigurationManager.ConnectionStrings["testing"].ConnectionString;
        SqlConnection connect = new SqlConnection(constr);        
        SqlCommand command = new SqlCommand("spdatabaseconnect",connect);
        command.CommandType = CommandType.StoredProcedure;
        command.Parameters.Add("@event", SqlDbType.TinyInt).Value = Atype;
        command.Parameters.Add("@EmpId", SqlDbType.Int).Value = EmpId ;
        command.Parameters.Add("@Emp_name", SqlDbType.NVarChar,50).Value = EmpName ;
        command.Parameters.Add("@Salary", SqlDbType.Int).Value = Salary ;
        command.Parameters.Add("@City", SqlDbType.NVarChar,50).Value = City ;
        connect.Open();
        command.ExecuteNonQuery();
        command.Connection.Close();
        command.Dispose(); 
        connect.Close();
       
    }

Also here are some other things you need to check.
1. make sure your connection string is correct.
2. make sure that the stored procedure you are calling exists

If you need to have save() and open() methods separately please refer to solution #1 and make this change in your button click

C#

Class1 obj = new Class1();
       obj.EmpId = Convert.ToInt32(txtEmpId.Text);
        obj.EmpName = txtEmpName.Text;
        obj.Salary = Convert.ToInt32(txtSalary.Text);
        obj.City = txtCity.Text;
        obj.Atype = Convert.ToInt32(txtEvent.Text);
        obj.open();
        obj.save();

the ado.net code is not working why?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0