Generating a new random!

Question

1.00/5 (1 vote)

See more:

Hello codeproject happy easter,

I am currently generating chunks with random blocks, however,
when I do this, the whole chunk is either grass, dirt, or stone, or air,
I am not sure why and that's why I came here. The new random always stays the same
in the void. I don't know why but it's frustrating, here is my code:

C#

/* Loop through the chunk to generate. */
    for (int i = 0; i < Chunk.ChunkWidth; i++)
    {
        for (int j = 0; j < Chunk.ChunkHeight; j++)
        {
            if (Chunk.ChunkY > 0)
            {
                int r = new Random().Next(0, 4);

                /* Set the material to dirt. */
                if (r == 0)
                    Block.MakeBlock(BlockMaterial.Material_Dirt);
                if (r == 1)
                    Block.MakeBlock(BlockMaterial.Material_Grass);
                if (r == 2)
                    Block.MakeBlock(BlockMaterial.Material_Stone);


            }
            else
            {
                /* Set the block material to air. */
                Block.MakeBlock(BlockMaterial.Material_Air);
            }

            /* Set the block. */
            Chunk.SetBlock(i, j, Block);
        }
    }
}

Posted 31-Mar-13 9:01am

Yvar Birx

Add a Solution

Comments

CPallini 31-Mar-13 15:29pm

What's the value of Chunk.ChunkY?
Why are you generating a random number in the range of 0,1,2,3 (inclusive) while you need just 0,1,2 ?

Yvar Birx 31-Mar-13 15:34pm

Chunk.ChunkY is the cooardinate of the Chunk, this is a way for me to only generate below the walking level, it's a bit like Flatgrass in Minecraft really. Oh, yeh, I am, I always forget about the fact that everything starts at zero not at one, however, the fact that the chunks are being generated like this:

http://i48.tinypic.com/ws5h5e.png

Has nothing to do with any of that. :L

Also, the colors are pretty much squares (32*32), which all show another chunk. So, you can see that the blocks are not random and I don't understand why.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Shahin Khorshidnia · Accepted Answer · 2013-03-31T09:04:00

Hi
Try this:

C#

var randomNumber = new Random();

/* Loop through the chunk to generate. */
    for (int i = 0; i < Chunk.ChunkWidth; i++)
    {
        for (int j = 0; j < Chunk.ChunkHeight; j++)
        {
            if (Chunk.ChunkY > 0)
            {
                var r =randomNumber.Next(0, 4);
 
                /* Set the material to dirt. */
                if (r == 0)
                    Block.MakeBlock(BlockMaterial.Material_Dirt);
                if (r == 1)
                    Block.MakeBlock(BlockMaterial.Material_Grass);
                if (r == 2)
                    Block.MakeBlock(BlockMaterial.Material_Stone);
 

            }
            else
            {
                /* Set the block material to air. */
                Block.MakeBlock(BlockMaterial.Material_Air);
            }
 
            /* Set the block. */
            Chunk.SetBlock(i, j, Block);
        }
    }
}

Maciej Los · Accepted Answer · 2013-03-31T10:58:00

Try to generate random numbers outside the loop.

C#

/* Loop through the chunk to generate. */
    for (int i = 0; i < Chunk.ChunkWidth; i++)
    {
        for (int j = 0; j < Chunk.ChunkHeight; j++)
        {
            if (Chunk.ChunkY > 0)
            {
                int r = RandomNumber(0, 4);

                /* Set the material to dirt. */
                if (r == 0)
                    Block.MakeBlock(BlockMaterial.Material_Dirt);
                if (r == 1)
                    Block.MakeBlock(BlockMaterial.Material_Grass);
                if (r == 2)
                    Block.MakeBlock(BlockMaterial.Material_Stone);


            }
            else
            {
                /* Set the block material to air. */
                Block.MakeBlock(BlockMaterial.Material_Air);
            }

            /* Set the block. */
            Chunk.SetBlock(i, j, Block);
        }
    }
}

private int RandomNumber(int min, int max)
{
Random random = new Random();
return random.Next(min, max);
}

Debug your program and check what RandomNumber function returns.

Generating a new random!

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0