random numbers in array

Question

2.00/5 (2 votes)

See more:

C#

int[] rnummer = new int[10];
Random ran = new Random();
int num = ran.Next(1,6);

for (int i = 0; i < 10; i++)
{
    rnummer[i] = ran.Next();
    Console.WriteLine(i);
}
    Console.ReadLine();

it is going to put in 10 int with random numbers between 1 -6 but know it only type in 0-9.

can anyone tell me where it is wrong

plz don't show me the salutation to the problem only help to solve it

Posted 7-Mar-13 11:04am

Tommy116

Add a Solution

Comments

Richard C Bishop 7-Mar-13 17:09pm

Your Console.Writeline() is only going to write whatever "i" is. It should read:

Console.WriteLine(rnummer[i].ToString());

Sergey Alexandrovich Kryukov 7-Mar-13 17:18pm

Only ToString part is redundant. The signature is WriteLine(params object[] param); and all all parameters are written via param[index].ToString() already.
—SA

Richard C Bishop 7-Mar-13 17:21pm

Ok, thank you. I did not know that.

Sergey Alexandrovich Kryukov 7-Mar-13 17:26pm

No problem, not you know. :-) I answered the question, but the way... Your comment is of course credited.
—SA

Tommy116 7-Mar-13 17:12pm

thx for it. know i need to get it to type 1 number and not 10 numbers at once

[no name] 7-Mar-13 17:14pm

"it is going to put in 10 int with random numbers between 1 -6 but know it only type in 0-9" I am not even sure what that means. Almost sounds like you need to change your random number parameters but I am not sure what it is that you are asking.

Tommy116 7-Mar-13 17:17pm

i need it to be like this when it print out
1
5
3
4
3
5
6
1
3
4

Richard C Bishop 7-Mar-13 17:27pm

Underneath your Console.WriteLine(rnummer[i]); add another writeline that is empty so it acts as a return to print it how you want.

Richard C Bishop 7-Mar-13 17:44pm

Shoot, I was not thinking, removing that part.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2013-03-07T11:22:00

You need to write rnumber[i] instead of i. Please see the very first comment by richcb and my comment below.

Also, you forgot to use num. You need to move your first line too lines lower, when num is already defined and replace your immediate constants of 10 by num in both array declaration and the loop (if it was your attention, otherwise it should be any explicitly defined constant). Hard-coding is really bad thing. Imagine you need to replace 10 by 13. Can you see how error-prone will it be?

Last statement is not very good, it's better to use System.Console.ReadKey(true); please see: http://msdn.microsoft.com/en-us/library/x3h8xffw.aspx[^].

The question itself wasn't correct. "What's wrong" makes no sense unless you explain what you wanted to achieve.

—SA

Matt T Heffron · Answer 2 · 2013-03-07T12:04:00

Solution 2

If I'm reading the orginal question correctly*, everyone seems to be missing that the call ran.Next() INSIDE the loop should be ran.Next(1,6) and the int variable num is actually unused/unnecessary.
Other comments about using named constants instead of hard-coding numbers and the correct expression in the Console.WriteLine() are correct.

* I read this as wanting 10 random values in the range 1 .. 6 (a throw of a dice?)

Posted 7-Mar-13 12:04pm

Matt T Heffron

Comments

Sergey Alexandrovich Kryukov 7-Mar-13 20:04pm

It actually called inside the loop, which makes sense. I thing, the (right) idea was to use random (1.. 6) for num, instead of "10" (which is an immediate constants repeated in code, really nasty). ran.Next() inside loop really does its job (depending on what was required)...
—SA

Matt T Heffron 7-Mar-13 20:06pm

It depends on the actual question.
We seem to interpret the question differently. ;)

Sergey Alexandrovich Kryukov 7-Mar-13 22:16pm

Not your fault, not my fault; it's just not a valid question. I only say that ran.Next() is actually is written inside the loop; and there is nothing wrong in its use. This is the invariant fact, I don't think you can deny it.
Thank you,
—SA

johannesnestler · Answer 3 · 2013-03-07T23:30:00

It seems OP is not more interested in this question. Anyway for the homework-googlers here is a summary of the above "tips" in code:

C#

using System;

namespace RollDices
{
    class Program
    {
        static void Main(string[] args)
        {
            Random rand = new Random();
            for (int i = 0; i < 10; i++)
                Console.WriteLine(rand.Next(1, 7)); 
            Console.ReadKey(true);
        }
    }
}

I think the question was to "roll a dice" 10 times - that for i used rand.Next(1, 7) this will give you numerbers from 1 to 6 (6 included) and not from 1 to 5 (6 not included) - common beginner mistake with Random...

random numbers in array

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0