What is the problem in my query

Question

0.00/5 (No votes)

See more:

SQL

declare @vc_supplier_name varchar(200) =''
declare @in_supplier_type_id int =2
declare @bt_active bit =1

SELECT a.in_supplier_id, dbo.format_fnc_bit(1, a.bt_active) AS vc_active, b.vc_supplier_type_name, a.in_supplier_type_id, a.vc_supplier_name,

    dbo.admin_user_fnc_get_name(1, a.in_updatedby_user_id) AS vc_updated_by, a.dt_updated

    FROM dbo.supplier a

    INNER JOIN dbo.common_data_vw_supplier_type b ON a.in_supplier_type_id = b.in_supplier_type_id

    WHERE a.in_supplier_type_id = @in_supplier_type_id AND a.vc_supplier_name LIKE '%' + @vc_supplier_name + '%'
    AND  a.bt_active = case @in_supplier_type_id when 2 THEN @bt_active

    ORDER BY a.vc_supplier_name

Error comes :Incorrect syntax near the keyword 'ORDER'.

here i want to use bt_active only if @in_supplier_type_id=2

Posted 14-Feb-13 8:56am

k@ran

Add a Solution

2 solutions

Solution 2

You need to add an "End" to the end of your case statement.

This:

AND  a.bt_active = case @in_supplier_type_id when 2 THEN @bt_active

should be this:

AND  a.bt_active = case @in_supplier_type_id when 2 THEN @bt_active End

You can also use an Else if need be.

Posted 14-Feb-13 9:02am

Richard C Bishop

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2013-02-14T09:02:00

Solution 1

Quote:
case @in_supplier_type_id when 2 THEN @bt_active

You missed the ending END ( :-) ) here.

Posted 14-Feb-13 9:02am

CPallini

v2

Comments

k@ran 14-Feb-13 15:13pm

Thanks CPallini It worked for @in_supplier_type_id =2

This query is not executing in case if @in_supplier_type_id is not 2..

What could be reason

fjdiewornncalwe 14-Feb-13 15:47pm

+5.

Espen Harlinn 15-Feb-13 9:04am

5'ed!