Error incorrect syntax near )

Question

0.00/5 (No votes)

See more:

When I click on submit it appears, I will be happy to help :)

What I have tried:

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data;

namespace ORI
{
    public partial class sign_up : System.Web.UI.Page
    {
        public string st = "";
        public string msg = "";
        public string sqlSelect = "";
        public string sqlInsert = "";
        protected void Page_Load(object sender, EventArgs e)
        {
            string fileName = "users2.mdf";
            string tableName = "usersTbL";

            if (Request.Form["submit"] != null)
            {
                string username = Request.Form["uName"];
                sqlSelect = "select uName from " + tableName;
                sqlSelect += " where uName = '" + username + "';";
                DataTable testTable = Helper.ExecuteDataTable(fileName, sqlSelect);
                
                if (testTable.Rows.Count != 0)
                {
                    msg = "user already exists";
                }
                else
                {
                    string id = Request.Form["id"];
                    string firstName = Request.Form["fName"];
                    string Nage = Request.Form["age"];
                    string prefix = Request.Form["prefix"];
                    string phone = Request.Form["phone"];
                    int Iage = int.Parse(Nage);

                    sqlInsert = "INSERT INTO " + tableName;
                    sqlInsert += "VALUES ('" + username + "'," + id + ",'" + firstName + "'," + Iage + "," + prefix + "," + phone + ");";

                    Helper.DoQuery(fileName, sqlInsert);

                }
            }
        }
    }
}

Posted 24-Feb-22 8:15am

ori samarel

Updated 24-Feb-22 10:04am

PIEBALDconsult

v2

Add a Solution

Comments

PIEBALDconsult 24-Feb-22 15:32pm

Please use a parameterized statement.

4 solutions

Solution 1

NOT like this:

sqlInsert = "INSERT INTO " + tableName;
                    sqlInsert += "VALUES ('" + username + "'," + id + ",'" + firstName + "'," + Iage + "," + prefix + "," + phone + ");";

because your code is Sql Injection[^] vulnerable!

Use parametrized queries instead!
Using Parameterized Queries with the SqlDataSource (C#) | Microsoft Docs[^]
How and Why to Use Parameterized Queries - Microsoft Tech Community[^]
Create Parameterized Queries in ADO.NET -- Visual Studio Magazine[^]

Posted 24-Feb-22 8:36am

Maciej Los

Solution 4

Firstly you really should be using a parameterized query as suggested by 'Patrice T and 'Maciej Los' to protect your database from SQL Injection.

If you had used a parameterized parameterized query you would not have to worry about balancing the single and double quotes especially when you get really large insert statements.

Your SQL statement is missing a few single quotes which is causing the problem.

However if you still want to use a string query the statement below should work.

SQL

string sqlInsert = "INSERT INTO " + tableName;
sqlInsert += " VALUES('" + username + "','" + id + "','" + firstname + "','" + Iage + "','" + prefix + "','" + telephone + "')";

I tested this and it does insert a record into the DB.

Posted 24-Feb-22 10:04am

Tony Hill

Updated 24-Feb-22 10:19am

v4

Comments

ori samarel 24-Feb-22 17:00pm

It's not working for me

Solution 2

I beleive phone is varchar and should be enclosed in quotes like following:

sqlInsert = "INSERT INTO " + tableName;
sqlInsert += " VALUES ('" + username + "'," + id + ",'" + firstName + "'," + Iage + "," + prefix + ",'" + phone + "');";

I would also recommend use the store procedure to insert the data. You can learn how to use store procedure through following link:
Lesson 07: Using Stored Procedures - C# Station[^]

Posted 24-Feb-22 8:38am

M Imran Ansari

Updated 24-Feb-22 9:48am

v2

Comments

ori samarel 24-Feb-22 14:49pm

It does not work yet, it displays the message "com.ExecuteNonQuery ();"

public static void DoQuery(string fileName, string sql)
{
SqlConnection conn = ConnectToDb(fileName);
conn.Open();
SqlCommand com = new SqlCommand(sql, conn);
com.ExecuteNonQuery();
conn.Close();
}

M Imran Ansari 24-Feb-22 15:49pm

I have updated my answer. There should also be a space before VALUES. Please check now

ori samarel 24-Feb-22 15:53pm

It still does not work, when I check the DB table there is no new data even after refresh

M Imran Ansari 24-Feb-22 16:16pm

OK. What is you final query? Can you post your sqlInsert value?

ori samarel 24-Feb-22 16:50pm

INSERT INTO usersTbL VALUES ('Maxim',258963417,'max',25,050,'9517427');

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2022-02-24T09:13:00

C#

sqlInsert = "INSERT INTO " + tableName;
sqlInsert += "VALUES ('" + username + "'," + id + ",'" + firstName + "'," + Iage + "," + prefix + "," + phone + ");";
//           ^ did you forgot a space before VALUES ?

Not necessary a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]

Error incorrect syntax near )

4 solutions

Solution 1

Solution 3

Solution 4

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us