How to convert nested if-else statement into conditional statement?

Question

0.00/5 (No votes)

See more:

C#

if (DmApiCacheUpdateStrategy.Equals("Delete"))
{
    subscribers.Add(new Subscriber()
    {
        Arguments = DmProject.GetDmProjectPath(dmProject),
        ExecutablePath = _apiDataPublisher.IeconPath,
        PostExecutionAction = _apiDataPublisher.OldFileCleanup
    });
}

else
{
    if (_apiDataPublisher != null)
    {
        subscribers.Add(new Subscriber()
        {
            Arguments = _apiDataPublisher.BuildExportArgumentsAndOutputPathForMergedCsv(DmProject.GetDmProjectPath(dmProject)).Item1,
            ExecutablePath = _apiDataPublisher.IeconPath,
            PostExecutionAction = _apiDataPublisher.OldFileCleanup
        });
    }
}

What I have tried:

C#

subscribers = DmApiCacheUpdateStrategy.Equals("Delete") ?
    subscribers.Add(
        new Subscriber
        {
            PostExecutionAction = _apiDataPublisher.OldFileCleanup
        }) :
    subscribers.Add(
        new Subscriber()
        {
        Arguments = _apiDataPublisher.BuildExportArgumentsAndOutputPathForMergedCsv(DmProject.GetDmProjectPath(dmProject)).Item1,
        ExecutablePath = _apiDataPublisher.IeconPath,
        PostExecutionAction = _apiDataPublisher.OldFileCleanup
        });

Posted 27-Jan-22 17:44pm

MayankSemwal

Updated 29-Jan-22 19:05pm

Sean Ewington

v5

Add a Solution

Comments

[no name] 27-Jan-22 23:59pm

Create a new "empty" Subscriber first; set the properties based on the if; then add it to the collection.

MayankSemwal 28-Jan-22 0:02am

Thanks for the reply Gerry. Is it possible for you to give an example?

3 solutions

Solution 1

A conditional statement is literally just a "compressed" if ... else statement:

C#

if (a)
   b;
else
   c;

And it becomes

C#

a ? b : c

But it's intended for assignments so it really needs the "expanded" version to be something like this:

C#

if (a)
   x = b;
else
   x = c;

Which becomes

C#

x = a ? b : c

As a result, both the b and c parts of the conditional statement must return the same types

Your original code isn't an assignment, so your "compressed" version doesn't do the same thing and probably should be something like

C#

subscribers.Add(DmApiCacheUpdateStrategy.Equals("Delete")) ?
                new Subscriber()    
                    {
                    Arguments = DmProject.GetDmProjectPath(dmProject),
                    ExecutablePath = _apiDataPublisher.IeconPath,
                    PostExecutionAction = _apiDataPublisher.OldFileCleanup
                    } :
                new Subcriber()
                    {
                    ...

Except that your original doesn't add an item in all cases so you can't convert the whole thing to a conditional statement at all!

Even if you could, the code you would end up with would be pretty impenetrable to read compared to the if ... else version, so I woudln't do it at all if I was you.

Posted 27-Jan-22 18:55pm

OriginalGriff

Comments

MayankSemwal 28-Jan-22 1:05am

Hello Griff,

This statement will not add but just compare subscribers.Add(DmApiCacheUpdateStrategy.Equals("Delete")).

Output: cannot convert from 'bool' to 'Subscriber'

OriginalGriff 28-Jan-22 1:41am

What part of "Except that your original doesn't add an item in all cases so you can't convert the whole thing to a conditional statement at all!" did you not understand?

MayankSemwal 28-Jan-22 1:45am

Understood. Sorry for that I was too focused on getting the result.

Solution 3

The simple (?) version:

A nested if/else structure defines a set of (explicit) conditions each of which is unique (mutually exclusive). For each unique condition, the programmer can supply an action )r, omit the action). Of course, a nested if/else structure that omits an action for each condition is ... purposeless.

A conditional statement in C# ... the Ternary Operator '?' ... returns a value: if you do not save the returned value, it is "lost." Each of the Ternary Operator's two outcomes must be specified explicitly, and their execution must return a valid object of the Type specied.

Posted 29-Jan-22 19:05pm

BillWoodruff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

_Asif_ · Accepted Answer · 2022-01-27T19:05:00

The very first step is to build the idea. May be like this

DmApiCacheUpdateStrategy.Equals("Delete") ? <true> : <false>;

Then improving a bit more

DmApiCacheUpdateStrategy.Equals("Delete") ? <true> : _apiDataPublisher != null ? <true> : <false>;

Further improvement could be like

DmApiCacheUpdateStrategy.Equals("Delete") ? AddSubscriber(DmProject.GetDmProjectPath(dmProject)) : _apiDataPublisher != null ? AddSubscriber(_apiDataPublisher.BuildExportArgumentsAndOutputPathForMergedCsv(DmProject.GetDmProjectPath(dmProject)).Item1) : <false>;

But then the question arises what to do if _api_dataPublisher is null.

I think your initial way of doing things with If else seems more maintenance-friendly instead of using it via a conditional operator. However you could rewrite the If conditions in following way

C#

if (DmApiCacheUpdateStrategy.Equals("Delete"))
{
    AddSubscriber(DmProject.GetDmProjectPath(dmProject))
}

else
{
    if (_apiDataPublisher != null)
    {
        string _t= _apiDataPublisher.BuildExportArgumentsAndOutputPathForMergedCsv(DmProject.GetDmProjectPath(dmProject)).Item1;
        AddSubscriber(_t);
    }
}

public void AddSubscriber(string _p)
{
//Try 
        subscribers.Add(new Subscriber()
        {
            Arguments = _p,
            ExecutablePath = _apiDataPublisher.IeconPath,
            PostExecutionAction = _apiDataPublisher.OldFileCleanup
        });
//Catch Block
}