Who do I get undefined reference all the time in C++?

Question

0.00/5 (No votes)

See more:

This is the problematic code:
"test.h":

C++

static bool All(bool* iterable);

"test.cpp":

C++

#include "test.h"
static bool All(bool* iterable) {
    for (int i = 1; i < (sizeof(iterable)/(sizeof(*iterable))); i++) {
        if (iterable[i] != iterable[0]) {
            return false;
        }
    }
    return true;
}

"main.cpp":

C++

#include "test.h"

int main(void) {
  bool test[] = { true, true, true };
  All(test);
  return 0;
}

And it gives me:

C++

undefined reference to 'All(bool*)'

When i try to compile. I am using g++ through a Makefile to compile if that helps.

What I have tried:

I tried moving the code to the .h file, it compiled but i have heard that is bad to do, presumably for performance.

Posted 18-Nov-21 11:28am

Member 14769677

Updated 20-Nov-21 16:05pm

v2

Add a Solution

6 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

k5054 · Answer 1 · 2021-11-18T12:36:00

The others have given you some direction to solve your issue, but are you aware there's a bug in your code? You have

bool All(bool *iterable) {
    for(int i = 1; i < sizeof(iterable)/sizeof(*iterable); ++i) {

C++ does not carry around array sizes, so sizeof(iterable) will be the size of a pointer on your system - probably 4 or 8 bytes. In this case sizeof(*iterable) equals sizeof(bool) which is 1. So the loop index will go from 1 to <bytes in="" pointer="">, regardless of how the array is that iterable points to.

The use of the sizeof division only works with arrays of known size at compile time e.g.

C++

double  d[]{ 1.0, 2.5, 3.14, 4.7, 5.0, 6.9, 17};  // d has 7 elements
size_t d_len = sizeof(d)/sizeof *d;  // d_len = 7

phil.o · Answer 2 · 2021-11-18T12:06:00

Solution 1

Outside of classes/structs, static in c++ means local to the file in which it is defined (i.e., inaccessible to outside world).
If the All method is not in a class, then delete the static storage qualifier from the method declaration, and all should be fine.

Posted 18-Nov-21 12:06pm

phil.o

Greg Utas · Answer 3 · 2021-11-18T12:09:00

Solution 2

Try removing static from the declaration and definition of All in test.h and test.cpp. Unless a function is a class member, defining it as static means that nothing outside the .cpp can see it. It will therefore appear to be declared in the interface but left unimplemented as far as main.cpp is concerned.

Posted 18-Nov-21 12:09pm

Greg Utas

Updated 18-Nov-21 12:10pm

v2

Comments

Member 14769677 18-Nov-21 23:13pm

I tried making it non-static, but it still won't compile. Same reason. I also tried to do what i would have done in C#, and put a public in front of it, didn't work either. Is this where i am supposed to use the extern keyword? How would i do that if that is the case?

Greg Utas 19-Nov-21 6:02am

Yes, you could use extern, though I don't think it should be necessary. In test.h, you would use "extern" where you had used "static". In test.cpp, you'd use neither.

Member 14769677 19-Nov-21 7:44am

Extern didn't work either, i find this really wierd and confusing xD

Greg Utas 19-Nov-21 8:08am

Sorry that I couldn't resolve this. I don't have any more suggestions to offer.

Member 14769677 19-Nov-21 12:07pm

Thank you for trying!

Greg Utas 19-Nov-21 6:06am

A follow-up question. *Where* does the "undefined reference" error occur? My guess is that it occurs during linking, not compiling. But if there is additional information, such as a file and/or line number, please provide it.

Member 14769677 19-Nov-21 7:42am

This is what the terminal says:
C:\Users\carlieboi\AppData\Local\Temp\ccT2hiu4.o:main.cpp:(.text.startup+0x25): undefined reference to 'All(bool*)'
collect2.exe: error: 1d returned 1 exit status
Makefile:2: recipe for target 'default' failed
mingw32-make: *** [default] Error 1

Rick York · Answer 4 · 2021-11-18T13:03:00

Just to elaborate on what k5054 wrote, there is a macro definition in Visual C++ that implements the sizeof division you have and it is called _countof. Its implementation looks like this :

C++

#define _countof(array) (sizeof(array) / sizeof(array[0]))

and it is documented here : _countof Macro | Microsoft Docs[^]. I don't know if it is available in other compilers but if not the definition given above can be utilized.

Muhammad Amir Ejaz · Answer 5 · 2021-11-18T20:30:00

You might have identify the problem in your code and Solution 3 stats a solution as well. But it will only work when you have the known number of elements of your array pre-hand.

On the other hand, you can maintain a Count variable which will be incremented/decremented for every insertion/deletion to the array. You can pass this variable to your ALL() function which then should use this variable in the loop. like

#include "test.h"
static bool All(bool* iterable, int count) {
    for (int i = 1; i < count; i++) {
        if (iterable[i] != iterable[0]) {
            return false;
        }
    }
    return true;
}

Member 14769677 · Answer 6 · 2021-11-20T16:05:00

Solution 6

I fixed it. I have to add the file in the makefile. Slight oversight, hehe.

Posted 20-Nov-21 16:05pm