How do I break away from this loop

Question

1.00/5 (2 votes)

See more:

I have a problem here when I was going to make a text-based adventure game. Here's My Code.

def adventure():
    print("You are in front of the towers' gate. Will you Enter?")
    ch = ""
    while ch.lower() != 'y' or ch.lower() != 'n':
        print("Please Choose")
        ch = input("[Y] or [N]: ")
        print(ch)
    print("You are out of the loop!")


adventure()

For some reason even though I put an input of "y" or "n" the loop still won't break.

What I have tried:

I tried making it take an int instead

def adventure():
    print("You are in front of the towers' gate. Will you Enter?")
    ch = ""
    while ch.lower() != 1 or ch.lower() != 2:
        print("Please Choose")
        ch = input("[1] or [2]: ")
        print(ch)
    print("You are out of the loop!"

adventure()

and as I expected... It still didn't break out of the loop

Posted 26-Oct-21 3:17am

N01Knowz

Updated 26-Oct-21 3:36am

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Answer 1 · 2021-10-26T03:32:00

Solution 1

That is because the test of your while loop is wrong: you wrote 'or' when you should've written 'and'.

Python

while ch.lower() != 'y' and ch.lower() != 'n':

Since a character cannot equal two values at the same time, an or test here yields to always return true.

Posted 26-Oct-21 3:32am

phil.o

Richard MacCutchan · Answer 2 · 2021-10-26T03:33:00

You are testing whether the entered character is not equal to Y or not equal to N. So if it is equal to Y it will not be equal to N, and vice versa. You need to test if it is not equal to both characters:

Python

while ch.lower() != 'y' and ch.lower() != 'n':

Now, if it is equal to Y or N it will exit the loop.

OriginalGriff · Answer 3 · 2021-10-26T03:36:00

Look at your condition:

Python

while ch.lower() != 'y' or ch.lower() != 'n':

If ch is "y" then it's not "n" - it can't be both.
Similarly, if ch is "n" then it's not "y"
So every time you check, one or other of those tests will be true, so it goes around again.

Try replacing or with and and it'll exit the loop when you enter one or the other.

How do I break away from this loop

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0