How do I calculate the average of all positive numbers in an array?

Question

1.00/5 (1 vote)

See more:

Any advice on how to debug this code? Everything is fine except it outputs the wrong number. var average = total / count;

{
            var total = 0;
            double count = 0;
            int i = 0;
            double[] arr1 = new double[20];

            for (i = 0; i < 20; i++)
            {

                Console.Write("Enter a number: ");
                string input = Console.ReadLine();


                if (input == "0") break;
                arr1[i] = int.Parse(input);


                if (int.TryParse(input, out int value) && value >= 0) 
                {
                    count++;

                }

                total = input.Count(s => s > 1) + value;

            }

                var average = total / count;
                Console.WriteLine($"Average of all positive numbers: {average}");
                Console.ReadKey();
            
            }

What I have tried:

I have tried using while method but that didnt help.

Posted 21-Oct-21 12:07pm

Agar Gamez

Updated 21-Oct-21 14:17pm

v3

Add a Solution

Comments

Patrice T 21-Oct-21 19:00pm

Elaborate !
What are the values of count total and average ?

BillWoodruff 21-Oct-21 19:59pm

repost of https://www.codeproject.com/Questions/5315673/How-do-I-fix-this-issue

however: requirement to ignore negative numbers is new.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

BillWoodruff · Accepted Answer · 2021-10-21T14:17:00

You are making progress ! Do use break-points and single-step (F11) through the code, observing exactly what happens.

Look how both total and count are updated only if there's a valid entry > 0/

double total = 0.0d;
double count = 0.0d;

double[] arr1 = new double[20];

for (int i = 0; i < 20; i++)
{
    Console.Write("Enter a number: ");
    string input = Console.ReadLine();

    if (input == "0") break;

    double parsedvalue = 0.0d;

    if (int.TryParse(input, out parsedvalue) && parsedvalue >= 0.0d) 
    {
        arr1[i] = int.Parse(input);
        total += parsedvalue;
        count++
    }

    // WHY ? ?total = input.Count(s => s > 1) + value;
}

double average = total / count;
Console.WriteLine($"Average of all positive numbers: {average}");
Console.ReadKey();