I need help what is wrong with my code? I can't get it to do any calculation

Question

1.00/5 (1 vote)

See more:

using System;
using System.Diagnostics;

namespace bmimetric.cs
{
    class bmimetric
    {

        public static object Main(string[] args)
        {
            String x, y;
            Console.WriteLine("Please enter weight in kilograms:");
            x = Console.ReadLine();
            int x1;
            x1 = 1 * 50;
            Console.WriteLine("x");
            Console.WriteLine("Please enter height in meters:");
            y = Console.ReadLine();
            int y1;
            y1 = (int)2.4964;
            Console.WriteLine("y");
            Console.WriteLine("The BMI is" + x1 / y1);
        }
                }
}

What I have tried:

I have tried math.pow i have tried float i have tried everything... also if someone knows a way I can get an easier version of visual studios on a mac please tell me

Posted 10-Oct-20 15:55pm

Emmanuel “E-man” Colon

Updated 10-Oct-20 20:23pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-10-10T20:23:00

Look at your code:

C#

            Console.WriteLine("Please enter weight in kilograms:");
            x = Console.ReadLine();
...
            Console.WriteLine("x");
            Console.WriteLine("Please enter height in meters:");
            y = Console.ReadLine();
...
            Console.WriteLine("y");

Year read in a value, ignore it, and print it out.
Why would you expect that to print anything other than exactly what you entered?
Then you calculate the BMI:

C#

            int x1;
            x1 = 1 * 50;
...
            int y1;
            y1 = (int)2.4964;
...
            Console.WriteLine("The BMI is" + x1 / y1);

Which - even if it worked, which it doesn't - would always print the same value!

Stop and think about what you are doing: why are you using integers to calculate a value that is not an integer? Why do you read height in meters and use integers? You will get 1 in nearly all adults, the rare 2, and 0 for a lot of children!

Integers hold "whole numbers": 0, 1, 2, 3, 4 ... (and negative whole numbers as well, of course).
Float or double numbers hold "fractional numbers": 1.6, 3.1415926, 2.7182818, ...

So when you cast 2.4964 (which would be a Giraffe, not a human) to an integer, you get ... 2.

Change your app to use double values throughout instead of int, and use the correct formula: Body mass index - Wikipedia[^] : weight / (height * height).

You will also need to convert the strings you read from the user to valid numbers:

C#

double weight;
if (!double.TryParse(userInputString, out weight)
   {
   Console.WriteLine($"\"{userInputString}\" is not a number!");
   return;
   }

Stop throwing code to together, and think about what you are trying to do first.

You may find this helps: How to Write Code to Solve a Problem, A Beginner's Guide[^]

Gerry Schmitz · Answer 2 · 2020-10-10T16:34:00

Solution 1

You need to learn the basics.

Tutorial: Create a simple C# console app - Visual Studio | Microsoft Docs[^]

Posted 10-Oct-20 16:34pm

Gerry Schmitz