RNG shooting - cant figure one thing

Question

0.00/5 (No votes)

See more:

Hello. My idea is 2 obejcts shooting against each other. And when someone will have 0 or less HP, program should stop running.

And I made it. It is working, but there is one thing which I should repair and cant figure it out!

My code looks like this:

C#

<pre>static void Main(string[] args)
        {
            int hp1 = 1200;
            int dps1 = 0;
            int dmg1 = 0;
            int hp2 = 1500;
            int dps2 = 0;
            int dmg2 = 0;
            Random tiger = new Random();
            Random mause = new Random();
            while (hp1 > dmg2 || hp2 > dmg1)
            {
                dps1 = tiger.Next(150, 300);
                Console.WriteLine(dps1 + " shooted to Mause.");
                dmg1 = dps1 + dmg1;
                dps2 = mause.Next(130, 350);
                Console.WriteLine(dps2 + " shooted to Tiger.");
                dmg2 = dps2 + dmg2;
                if (dmg2 > hp1) { Console.WriteLine("Mause won!"); }
                else if (dmg1 >hp2) { Console.WriteLine("Tiger won!"); }
            }
            Console.ReadKey();
        }

When I run this, everything is ok. But at the end - output is like this:

225 shooted to Mause.
247 shooted to Tiger.
238 shooted to Mause.
277 shooted to Tiger.
Mause won!
227 shooted to Mause.
150 shooted to Tiger.
Mause won!

Why it always write, Mause won 2 times? When dmg2 is higher than hp1, it should end the program. Why there is next shoots and winner written twice?

What I have tried:

Im little bit experienced with rng, but I have no clue what Im a doing wrong here. Any ideas?

Posted 4-May-20 10:27am

sOwlO

Updated 4-May-20 10:50am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2020-05-04T10:51:00

Quote:
And when someone will have 0 or less HP, program should stop running.

But your code is wrong.
This code:

C#

while (hp1 > dmg2 || hp2 > dmg1)

loop as long as 1 of both objects have hp remaining.
And this code:

C#

while (hp1 > dmg2 && hp2 > dmg1)

loops as long as both objects have remaining hp.

And with this code, Tiger is not checked when mause won.

C#

if (dmg2 > hp1) { Console.WriteLine("Mause won!"); }
else if (dmg1 >hp2) { Console.WriteLine("Tiger won!"); }

Try this code instead:

C#

if (dmg2 > hp1) { Console.WriteLine("Mause won!"); }
if (dmg1 >hp2) { Console.WriteLine("Tiger won!"); }

Advice: Mixing indices is a bad idea, it just make things more complicated, it is easier to design so indices match. Like:

C#

if (dmg1 > hp1) { Console.WriteLine("Mause won!"); }
if (dmg2 >hp2) { Console.WriteLine("Tiger won!"); }

-----
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

Debugging C# Code in Visual Studio - YouTube[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.