How to fix the syntax error (missing operator) using visual studio 2019 with MS access database

Question

0.00/5 (No votes)

See more:

C#

private void btnSave_Click(object sender, EventArgs e)
        {
            //Sale table

            {
                string str = "INSERT INTO Sales (Invoice,CustomerName,SaleDate,TotalAmt,VAT,Discount,TotalPayAmt,Paid,Balance) VALUES ("+ Invoice_tx.Text +", '"+ CustomerName_cb.Text +"', '"+ SaleDate_dt.Value.Date.ToString() +"', "+ TotalAmnt_tx.Text +", "+ VAT_tx.Text +", "+ Discount_tx.Text +", "+ TotalPayAmnt_tx.Text +", "+ Paid_tx.Text +", "+ Balance_tx.Text +") ";

                OleDbDataAdapter da = new OleDbDataAdapter(str, conn);               
                //DataSet ds = new DataSet();
                DataTable dt = new DataTable();
                da.Fill(dt);
                
            }
            //SaleItem table

            for (int i = 0; i < metroGrid1.Rows.Count; i++)
            {
                string insertPur = "INSERT INTO SaleItems (Invoice,Pid,Product,Qty,Rate,Amount) VALUES ( " + Invoice_tx.Text + ", " + metroGrid1.Rows[i].Cells["Pid"].Value.ToString() + ", '" + metroGrid1.Rows[i].Cells["Product"].Value.ToString() + "',  " + metroGrid1.Rows[i].Cells["Qty"].Value.ToString() + ", " + metroGrid1.Rows[i].Cells["Rate"].Value.ToString() + ", " + metroGrid1.Rows[i].Cells["Amount"].Value.ToString() + ") ";

                OleDbDataAdapter da = new OleDbDataAdapter(insertPur, conn);
                DataSet ds = new DataSet();
                da.Fill(ds);

            }
            //Stock Table
            {

                for (int i = 0; i < metroGrid1.Rows.Count; i++)
                {
                    OleDbDataAdapter da1 = new OleDbDataAdapter("SELECT * FROM Stock WHERE Pid= " + metroGrid1.Rows[i].Cells["Pid"].Value.ToString() + " AND Product= '" + metroGrid1.Rows[i].Cells["Product"].Value.ToString() + "'  ", conn);
                    DataSet ds1 = new DataSet();
                    da1.Fill(ds1);

                    if (ds1.Tables[0].Rows.Count > 0)

                    {

                        //When Item exist in stock!

                        string insertPur = "UPDATE Stock SET Qty= Qty- " + metroGrid1.Rows[i].Cells["Qty"].Value.ToString() + " Where Pid=" + metroGrid1.Rows[i].Cells["Pid"].Value.ToString() + " ";

                        OleDbDataAdapter da = new OleDbDataAdapter(insertPur, conn);
                        DataSet ds = new DataSet();
                        da.Fill(ds);
                    }
                    else
                    {
                        //When Item doesn't exist in stock!

                        string insertPur = "INSERT INTO Stock (Pid,Product,Qty,Rate,Amount) VALUES (" + metroGrid1.Rows[i].Cells["Pid"].Value.ToString() + ", '" + metroGrid1.Rows[i].Cells["Product"].Value.ToString() + "', " + metroGrid1.Rows[i].Cells["Qty"].Value.ToString() + ", " + metroGrid1.Rows[i].Cells["Rate"].Value.ToString() + ",  " + metroGrid1.Rows[i].Cells["Amount"].Value.ToString() + " ) ";

                        OleDbDataAdapter da = new OleDbDataAdapter(insertPur, conn);
                        DataSet ds = new DataSet();
                        da.Fill(ds);
                    }

                }
            }

            MessageBox.Show("The Record Saved Successfully!", "SAVE", MessageBoxButtons.OK, MessageBoxIcon.Information);

            Clear();
            ClearItems();       
            metroGrid1.Rows.Clear();
            NewInvoice();


        }

What I have tried:

I had tried to execute the app many times but still not work it shows the message the syntax error (missing operator) I used MS Access Database and Visual Studio 2019, please help me how to resolve this problem

Posted 8-Apr-20 17:00pm

Member 14796688

Updated 8-Apr-20 22:56pm

CHill60

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2020-04-08T17:46:00

Quote:
it shows the message the syntax error (missing operator)

Give exact error message, it usually include the filename and line number where is the error.

C#

string str = "INSERT INTO Sales (Invoice,CustomerName,SaleDate,TotalAmt,VAT,Discount,TotalPayAmt,Paid,Balance) VALUES ("+ Invoice_tx.Text +", '"+ CustomerName_cb.Text +"', '"+ SaleDate_dt.Value.Date.ToString() +"', "+ TotalAmnt_tx.Text +", "+ VAT_tx.Text +", "+ Discount_tx.Text +", "+ TotalPayAmnt_tx.Text +", "+ Paid_tx.Text +", "+ Balance_tx.Text +") ";

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]

CHill60 · Answer 2 · 2020-04-08T22:56:00

In the code at the very start

C#

string str = "INSERT INTO Sales (Invoice,CustomerName,SaleDate,TotalAmt,VAT,Discount,TotalPayAmt,Paid,Balance) VALUES ("+ Invoice_tx.Text +", '"+ CustomerName_cb.Text +"', '"+ SaleDate_dt.Value.Date.ToString() +"', "+ TotalAmnt_tx.Text +", "+ VAT_tx.Text +", "+ Discount_tx.Text +", "+ TotalPayAmnt_tx.Text +", "+ Paid_tx.Text +", "+ Balance_tx.Text +") ";

you have a non-printing character in the +", "+ between TotalPayAmnt_tx.Text and Paid_tx.Text.

In fact if I paste that section into, say the VBE in Excel it shows as

TotalPayAmnt_tx.Text +",??? "+ Paid_tx.Text

It's those ??? that are causing your syntax error.

If you follow the advice of Patrice T (@ppolymorphe) in Solution 2, and use Parameterized queries then the problem unfortunately won't go away (which is unusual in these cases) - the solution is to delete that character that looks like a space, but which isn't.

But you really, really should use parameterized queries as well e.g. (untested)

C#

string str = "INSERT INTO Sales (Invoice,CustomerName,SaleDate,TotalAmt,VAT,Discount,TotalPayAmt,Paid,Balance) VALUES (?,?,?,?,?,?,?,?,?)";
OleDbDataAdapter da = null;
// these must be in the right order!
da.SelectCommand.Parameters.Add("invoice",OleDbType.VarChar, 100).Value = Invoice_tx.Text;
//etc

Garth J Lancaster · Answer 3 · 2020-04-08T17:31:00

1) I think you should use Visual Studio to narrow down in which statement your error occurs, then update this question

2) putting SQL together like that is just so passe (dangerous, old, WRONG) even for a boomer like me - and as you've seen, prone to hard to spot errors - have a look at https://stackoverflow.com/questions/9433148/generating-sql-queries-safely-in-c-sharp and https://docs.microsoft.com/en-us/dotnet/api/system.data.sqlclient.sqlparameter?redirectedfrom=MSDN&view=netframework-4.8

How to fix the syntax error (missing operator) using visual studio 2019 with MS access database

3 solutions

Solution 2

Solution 3

Solution 1

Add your solution here

Preview 0