Function to get the ratio of the number of positive, negative, and null values inside an array in relation to its length

Question

0.00/5 (No votes)

See more:

I wrote a function that checks what's the ratio of the number of positive, negative and null values inside an array in relation to its length.

I'd like receive some feedback on why my code's logic doesn't work.

What I have tried:

The code I wrote is the following:
```
function plusMinus(arr) {

    /**first I declare 3 variables to store the positive, 
    negative and null elements inside them*/

    let numPositive = [];
    let numNegative = [];
    let numZero = [];

    /**then I write a loop that will check whether 
    the elements of the input array are positive, negative or null,
    e.g. if the element[i] is positive, then the array 
    numPositive pushes the positive element[i] inside it, 
    and so on for the rest of the numbers and arrays*/

    for (let i=0; i<arr.length;i++){
        if (arr[i]>0){
            numPositive.push(arr[i]>0);
        }else if (arr[i]<0){
            numNegative.push(arr[i]<0);
        }else{
            numZero.push(arr[i]==0)
        }
    }

    /**finally, the ratios are given as a result of 
    the length of the pushed arrays and the length of the original array*/

    console.log(numPositive.length/arr.length);
    console.log(numNegative.length/arr.length);
    console.log(numZero.length/arr.length);
}
```

Posted 19-Jan-20 14:00pm

alvaropazz

Updated 19-Jan-20 17:11pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2020-01-19T16:30:00

Your code is over engineered !
You build 3 arrays to use only their length, the length of an array is the number of items in the array, you just need to count the number.
So 3 numeric variables and increments are enough to get the answer.
With a toy program on modern PC, it doesn't really matters, but on real programs likes interactive games it have a real impact on the fps because of resources hog.
The right question is do I really need to do it that way ? Can I simplify ?
-----

Quote:
I'd like receive some feedback on why my code's logic doesn't work.

If your code does not work, you should explain who, what is the problem.
-----
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

JavaScript Debugging[^]
Chrome DevTools | Web | Google Developers[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Wendelius · Answer 2 · 2020-01-19T17:12:00

There are at least a few problems

You don't push the values into the arrays. At the moment you push a boolean value based on a condition.

In other words instead of

numPositive.push(arr[i]>0);

You should use

numPositive.push(arr[i]);

The other thing is that you don't check for a null value so zeros and nulls go to the same category. Based on the description this isn't intentional

Function to get the ratio of the number of positive, negative, and null values inside an array in relation to its length

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0