Counter in SQL from C#

Question

1.50/5 (2 votes)

See more:

I try this

I have reslult
1
1
1
..

Need to have
1
2
3
..

What I have tried:

<pre>declare @maxNo integer = 0 select @maxNo = isnull(max(redni_broj), 0) from [dbo].[prenosnica_roba] WHERE id_fakture=3;Set @maxNo=@maxNo+1;
INSERT into dbo.prenosnica_roba (redni_broj)
     SELECT  @maxNo
    FROM dbo.mp_racun_roba

Posted 19-Nov-19 23:31pm

Goran Bibic

Updated 19-Nov-19 23:42pm

Add a Solution

2 solutions

Solution 1

You probably can use one of the ranking functions of SQL for that...
Ranking Functions (Transact-SQL) - SQL Server | Microsoft Docs[^]

Posted 19-Nov-19 23:41pm

Kornfeld Eliyahu Peter

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2019-11-19T23:43:00

You set @MaxNo to the current max value from your table - but you don't change that value. So the first time it finds a value, it will duplicate it ad infinitum. Probably, you want to increment @MaxNo before you insert - but that's not a good idea.
Almost certainly, what you actually want to do is to use an IDENTITY value instead, and lest the DB sort it out for you: IDENTITY (Property) (Transact-SQL) - SQL Server | Microsoft Docs[^]