sql query not working correctly

Question

0.00/5 (No votes)

See more:

SQL

USE [cms]
    GO
    /****** Object:  StoredProcedure [dbo].[SpGetRelatedProducts]    Script Date: 10/10/2012 14:35:39 ******/
    SET ANSI_NULLS ON
    GO
    SET QUOTED_IDENTIFIER ON
    GO
    ALTER proc [dbo].[SpGetRelatedProducts](@pid int)
    AS
    DECLARE @subcate int;
    select subcate_id as subcate from product where pid=@pid
    SELECT *
    FROM product
    where product.subcate_id=@subcate
       
    exec SpGetRelatedProducts 2

the given above sql query not working correctly as wanted.......???
i want the aproduct details of only those , which has subcatid=(subcatid of given pid)..???
there r 2 issues
1.... only 1 output should appear instead of 2

2.... 2nd one not working correctly(second output)

Posted 9-Oct-12 23:18pm

ashokdamani

Updated 9-Oct-12 23:20pm

Rajeev Jayaram

v2

Add a Solution

Comments

AshishChaudha 10-Oct-12 5:29am

Please provide the table structure of both the tables....

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

AshishChaudha · Answer 1 · 2012-10-09T23:31:00

Solution 1

Try following

SQL

select * from product where subcate_id in (SELECT subcate_id FROM product where pid=@pid)

The above query gives the details of all the products which has subcate_id of the subcate_Id matches in product.

Thanks

Posted 9-Oct-12 23:31pm

AshishChaudha

Comments

[no name] 10-Oct-12 8:35am

my 5

damodara naidu betha 11-Oct-12 1:05am

Hi,
I have a doubt. Why we need to check twice in same product table?. We can do the same like select * from product where pid=@pid.. instead of using the sub query.Both select * from product where subcate_id in (SELECT subcate_id FROM product where pid=@pid) and select * from product where pid=@pid give same result and select * from product where pid=@pid is more efficient than your query because it is avoiding 'in' and sub query.

AshishChaudha 11-Oct-12 1:28am

I asked for the table structure..as per your requirement, I told you this query..

damodara naidu betha · Answer 2 · 2012-10-10T03:58:00

Solution 2

Hi ... use this code block...

SQL

ALTER proc [dbo].[SpGetRelatedProducts](@pid int)
AS
SELECT * FROM product
where product.pid=@pid

Thank you

Posted 10-Oct-12 3:58am

damodara naidu betha