Timer freeze when using "While" in c#

Question

1.00/5 (1 vote)

See more:

Hello

I want to have a timer that is run after pushing a button.
after a predefined time it should set a bit.
In the button procedure I wait for that bit.but it freezes in the "while"'!!!!

C#

private void btnStart_Click(object sender, EventArgs e)
   {
       timer1.Interval = 100;
       TimerEnd = false;
       label1.Text = "Process Started...";
       timer1.Enabled = true;
       while (!TimerEnd) ;
       label1.Text = "Process Finished";

   }

   private void timer1_Tick(object sender, EventArgs e)
   {
       counter++;
       if (counter > 10)
       {
           TimerEnd = true;
           counter = 0;
       }

   }

Posted 16-Aug-12 11:24am

Reza29ir

Updated 8-Dec-19 5:44am

Add a Solution

Comments

Sergey Alexandrovich Kryukov 16-Aug-12 17:28pm

The exact type of the timer please. It's critically important. Isn't it System.Windows.Forms.Timer? System.Timers.Timer?
--SA

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Clifford Nelson · Answer 1 · 2012-08-16T12:30:00

    private void btnStart_Click(object sender, EventArgs e)
        {
            timer1.Interval = 100;
Add ->      timer1.Tick += timer1_Tick
            TimerEnd = false;
            label1.Text = "Process Started...";
            timer1.Enabled = true;
            while (!TimerEnd) ; 
            label1.Text = "Process Finished";
        }
 
        private void timer1_Tick(object sender, EventArgs e)
        {
            counter++;
            if (counter > 10)
            {
                TimerEnd = true;
                counter = 0;
            }      
        }

You never set the event handler.

Ashutosh Gpta · Answer 2 · 2019-12-08T05:44:00

Solution 5

how abt this. this is what you are looking i guess.
System.Timers.Timer time = new System.Timers.Timer(100);
time.Elapsed += Time_Elapsed;

private static void Time_Elapsed(object sender, System.Timers.ElapsedEventArgs e)
{
label1.Text = "Process Finished";
}

Posted 8-Dec-19 5:44am

Ashutosh Gpta

Comments

Dave Kreskowiak 8-Dec-19 11:45am

Try reading the other answers along with the question, and looking at the date on the question before answering. This one is 7 years old. I seriously doubt the OP is still looking for an answer.

Ashutosh Gpta 8-Dec-19 11:59am

why do you think so that is only for OP not for others in future until and unless they get the right answer. anyway i didnt realize the date but this question was appearing on top of list to answer. down vote for answering without noticing date of question asked, anyways i dont mind of down vote, it is going to help some one in future for sure.

Dave Kreskowiak 8-Dec-19 14:02pm

Because your answer was nothing more than a stripped down version of Solution 2 with no explanation of what the OP missed doing.

hgh6484 · Answer 3 · 2019-12-08T03:51:00

Solution 4

Hi, Just replace

while (!TimerEnd) ;

with

while (!TimerEnd)
{
    Application.DoEvents();
}

Posted 8-Dec-19 3:51am

hgh6484

Comments

Dave Kreskowiak 8-Dec-19 10:36am

no, No, NO. Application.DoEvents() is a bad solution to anything. If you're using it, you're doing threading, or something else, very wrong. DoEvents introduces problems in your code if you don't have any idea what it does behind the scenes. One example is event handlers that shouldn't be started again if it is already running.

The OP's question, from 7 YEARS AGO, was due to a poor understanding of how threading works and, today, the pattern he demonstrated would be better handled with Tasks.

hgh6484 11-Jan-22 10:43am

Dear Dave!
It's not the best answer, I just notify how that code can run and debug.

Dave Kreskowiak 11-Jan-22 10:55am

Telling someone to use DoEvents when THEY don't know what it does or how it works is an even worse idea.