Help to Display a Error message when checking the string from Arraylist

Question

3.00/5 (2 votes)

See more:

Helloo,

i confused into display a error message when comapre the textbox data from the ArrayList.

i have 100 data into Arraylist. and i compare the textbox value with condition like :

id_user is a name of Arraylist.

for (int k = 0; k < id_user.Count; k++)
{
       if (id_user[k].Equals(txt_uname.Text))
       {
             string username = "select ID,password from empl where id='" + txt_uname.Text + "' and password='" + txt_pass.Text + "'";
             SqlDataAdapter ad = new SqlDataAdapter(username, c.getcon());
             DataSet ds = new DataSet();
             ad.Fill(ds);
             c.close();
             if (ds.Tables[0].Rows.Count != 0)
             {
                    // do something
             }
             else
             {
                   Label4.Text = "Invalid Username or Password";
             }
       }
       else
       {
          Label4.Text = "You Are Not Authorized User";
       }

}

so this is a problem:
if a arraylist have 5 records and match the condition on 1st record but not enter proper id and password it also display the else message because it continue to check
the remaning 4 data and execute the error message of that last record.

so i want to do that if it match the condition and not enter proper id and password it display first error message " invalid ...." else another message if not match from the entire Arraylist.

Please help me....
Thanks in advance....
Mitesh

Posted 5-Jul-12 21:19pm

Mits Machhi

Updated 5-Jul-12 21:20pm

Prasad_Kulkarni

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 6-Jul-12 3:24am

This is not a question. Why cannot you do exactly what you describe in this post?
--SA

Sergey Alexandrovich Kryukov 6-Jul-12 3:25am

By the way, don't use obsolete ArrayList, use System.Collections.Generic.List<>.
--SA

[no name] 6-Jul-12 3:25am

i tried but not success, so then after i want to help from you.

Sergey Alexandrovich Kryukov 6-Jul-12 3:28am

"Not success" is not descriptive; we cannot work out any solution from that.
Also, do not use string concatenation, use parametrized commands. What you do is opening the wide door the the SQL Injection (read about this exploit in Wikipedia).
--SA

[no name] 6-Jul-12 3:31am

ok. thanks for suggestion but how t stop that arraylist selection.

2 solutions

Solution 2

you can put "Invalid Username or Password" this message in a different variable as messege and display final message after comparing Label4.text and message, if once for loop satisfies
condition if (id_user[k].Equals(txt_uname.Text))then name is in arraylist and if it is in database then do smething show appropriate message in Label4 (if needed) and break the loop.

Please try this.

id_user is a name of Arraylist.

C#

string messege="";
for (int k = 0; k < id_user.Count; k++)
{
       if (id_user[k].Equals(txt_uname.Text))
       {
             string username = "select ID,password from empl where id='" + txt_uname.Text + "' and password='" + txt_pass.Text + "'";
             SqlDataAdapter ad = new SqlDataAdapter(username, c.getcon());
             DataSet ds = new DataSet();
             ad.Fill(ds);
             c.close();
             if (ds.Tables[0].Rows.Count != 0)
             {
                    // do something
Label4.Text ="valid user";
break;
             }
             else
             {
                  messege = "Invalid Username or Password";
             }
       }
       else
       {
          Label4.Text = messege==""?"You Are Not Authorized User":messege;
       }
 
}

Posted 5-Jul-12 21:50pm

SoumenBanerjee

Updated 5-Jul-12 22:16pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

kornakar · Accepted Answer · 2012-07-05T21:32:00

I think you need a variable authState (or similar) which is set when authentication is succeeded/failed.
Just set the value within the for loop and then check the variable's value after. Notice the break statement which terminates the loop.

Example:

// 0 for not authorized
// 1 for invalid user/pass
// 2 for success
// NOTE: this could also be enum
int authState = 0;
for (int k = 0; k < id_user.Count; k++)
{
       if (id_user[k].Equals(txt_uname.Text))
       {
             string username = "select ID,password from empl where id='" + txt_uname.Text + "' and password='" + txt_pass.Text + "'";
             SqlDataAdapter ad = new SqlDataAdapter(username, c.getcon());
             DataSet ds = new DataSet();
             ad.Fill(ds);
             c.close();
             if (ds.Tables[0].Rows.Count != 0)
             {
                    // do something
                   authState = 2;
                   break;
             }
             else
             {
                   authState = 1;
                   break;
             }
       }
       // this branch is not needed because 0 is default value for authState
       else
       {
          authState = 0;
       }
 
}

// Check the result
switch(authState)
{
   case 0:
      Label4.Text = "You Are Not Authorized User";
      break;
   case 1:
      Label4.Text = "Invalid Username or Password";
      break;
   case 2:
      Label4.Text = "Success".
      break;
}