The SelectCommand property has not been initialized before calling 'Fill'......any one tell what error this

Question

0.00/5 (No votes)

See more:

when i select Dropdownlist items i have to show particular item data into listbox
how can i do this

this is my storeprocedure...

SQL

CREATE PROCEDURE [dbo].[StoredProc1]
@player_id int

AS
BEGIN
     SELECT full_name FROM Players WHERE player_id = @player_id



END

this is my cs code...

C#

protected void DropDownList1_SelectedIndexChanged(object sender, EventArgs e)
       {
           try
           {

                   if (DropDownList1.SelectedItem != null)
                   {
                      
                       con = new SqlConnection(connection);
                       SqlCommand command = new SqlCommand("[dbo].[StoredProc1]", con);

                       command = new SqlCommand(qry, con);
                      SqlParameter("@player_id",                       DropDownList1.SelectedValue));

                       command.Parameters.Add("@player_id", SqlDbType.NVarChar).Value = DropDownList1.SelectedValue;
                       command.CommandType = CommandType.StoredProcedure;
                       SqlDataAdapter da = new SqlDataAdapter(cmd);

                       da.Fill(ds);
                        ListBox1.DataSource = ds;
                       ListBox1.DataTextField = "player_id";
                       ListBox1.DataBind();

                   }
           }
           catch (Exception ex)
           {
               throw ex;
           }

Posted 22-Jun-12 0:19am

rockpune

Updated 22-Jun-12 0:25am

Vani Kulkarni

v2

Add a Solution

Comments

[no name] 22-Jun-12 7:36am

What is "qry" doing here? Can you please tell me?

Vani Kulkarni 25-Jun-12 0:03am

Did you get the solution?

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Answer 1 · 2012-06-22T00:44:00

See on how SQLDataAdapter is used with command as parameter: MSDN: SqlDataAdapter Constructor (SqlCommand)[^]

Internally, it's the Select command that is initialized for it.

Try to use it like this as it will be simple to read and understand:

C#

con = new SqlConnection(connection);
SqlCommand command = new SqlCommand("[dbo].[StoredProc1]", con); 
command = new SqlCommand(qry, con);
SqlParameter("@player_id",DropDownList1.SelectedValue));
command.Parameters.Add("@player_id", SqlDbType.NVarChar).Value = DropDownList1.SelectedValue;
command.CommandType = CommandType.StoredProcedure;
// changed this line
SqlDataAdapter da = new SqlDataAdapter();
// changed this line
da.SelectCommand = command;
da.Fill(ds);

Further, you need to bind the list with a datatable and not dataset.

C#

ListBox1.DataSource = ds.Tables[0];
ListBox1.DataTextField = "player_id";

Vani Kulkarni · Answer 2 · 2012-06-22T00:28:00

Solution 1

You are missing this line of code:

C#

DataSet ds = new DataSet();

You need to write it before you fill it, i.e., before the below line:

C#

da.Fill(ds);

Posted 22-Jun-12 0:28am

Vani Kulkarni

Comments

Sandeep Mewara 22-Jun-12 6:38am

I doubt if this is the reason.

'ds' must have been initialized earlier.

rockpune 22-Jun-12 6:39am

still not getting dropdownlist value into listbox

AmitKumar89 · Answer 3 · 2012-06-22T01:22:00

Hi,

Try this:

C#

protected void DropDownList1_SelectedIndexChanged(object sender, EventArgs e)
{
           try
           {
 
                   if (DropDownList1.SelectedItem != null)
                   {
                      
                       con = new SqlConnection(connection);
                       con.Open();//This is required always
                       SqlCommand command = new SqlCommand("[dbo].[StoredProc1]", con);
 
                       //command = new SqlCommand(qry, con); *not required
                       command.CommandType = CommandType.StoredProcedure; //Replaced. before adding parameter must declare command type
 
                       command.Parameters.Add("@player_id", SqlDbType.NVarChar).Value = DropDownList1.SelectedValue;

                       SqlDataAdapter da = new SqlDataAdapter(command);

                       DataSet ds=new DataSet();

                       da.Fill(ds);
                       con.Close();
                       ListBox1.DataSource = ds;
                       ListBox1.DataTextField = "player_id";
                       ListBox1.DataBind();
 
                   }
           }
           catch (Exception ex)
           {
               throw ex;
           }
}

All the best.
--AK

Vasim889 · Answer 4 · 2012-06-22T01:33:00

C#

con = new SqlConnection(connection);
dt= new datatable();
SqlCommand command = new SqlCommand("[dbo].[StoredProc1]", con); 
command = new SqlCommand(qry, con);
SqlParameter("@player_id",DropDownList1.SelectedValue));
command.Parameters.Add("@player_id", SqlDbType.int).Value = DropDownList1.SelectedValue;
command.CommandType = CommandType.StoredProcedure;

SqlDataAdapter da = new SqlDataAdapter();

da.SelectCommand = command;
da.Fill(dt);
con.close();

ListBox1.DataSource = dt[0];
ListBox1.DataTextField = "playerID";

The SelectCommand property has not been initialized before calling 'Fill'......any one tell what error this

4 solutions

Solution 2

Solution 1

Solution 3

Solution 4

Add your solution here

Preview 0