Input string was not in a correct format

Question

4.25/5 (6 votes)

See more:

I have a dropdown list that has a different datafield(CouponName) and datavalue(CouponTypeID). I want the code to work so that when I select a datafield it saves datavalue in database but it shows an error::

Input string was not in a correct format

protected void btnSubmit_Click(object sender, EventArgs e)
    {
        try
        {
            ErrorMessage.Text = "";
            cnx.Open();
            SqlCommand insertCmd = new SqlCommand(
                "insert into CouponTransaction(CouponTypeID)values(@id)", cnx);
                        
            insertCmd.Parameters.Add("@Id", SqlDbType.TinyInt);
            insertCmd.Parameters["@Id"].Value =
                Int32.Parse (ddlCType.SelectedValue);
           
          
            insertCmd.ExecuteNonQuery();
            ErrorMessage.Text = "Records inserted successfully";
            cnx.Close();
        }
        catch (Exception ex)
        {
            ErrorMessage.Text = ex.Message;
        }

Posted 13-Aug-09 22:33pm

haleemasher

Updated 19-Mar-10 11:51am

Mohd Arshad Malik

v3

Add a Solution

Comments

Christian Graus 3-Jun-10 23:03pm

Seriously, why would someone edit or reply to a question from 6 months ago ? If he's not solved it now, he's never going to, people.

10 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

M.Premraj · Answer 1 · 2009-12-26T03:02:00

the below code never makes issue. And try to use int.tryParse instread of
int.parse.

tryParse is performing with very less conversion time.

protected void btnSubmit_Click(object sender, EventArgs e)
    {
        try
        {
	    int cardTypeId = 0;
            if (ddlCType.selectedIndex >=0)
            {
            int.tryParse(ddlCType.SelectedValue.toString(),out cardTypeId);
           }
            ErrorMessage.Text = "";
            cnx.Open();
            SqlCommand insertCmd = new SqlCommand(
                "insert into CouponTransaction(CouponTypeID)values(@id)", cnx);
                        
            insertCmd.Parameters.Add("@Id", SqlDbType.TinyInt);
            insertCmd.Parameters["@Id"].Value =  cardTypeId;
           
          
            insertCmd.ExecuteNonQuery();
            ErrorMessage.Text = "Records inserted successfully";
            cnx.Close();
        }
        catch (Exception ex)
        {
            ErrorMessage.Text = ex.Message;
        }
   }

Happy coding

Vimalsoft(Pty) Ltd · Answer 2 · 2009-08-13T22:55:00

Good day haleemasher

Change your code to

protected void btnSubmit_Click(object sender, EventArgs e)<br />    {<br />        try<br />        {<br />            ErrorMessage.Text = "";<br />            cnx.Open();<br />            SqlCommand insertCmd = new SqlCommand("insert into CouponTransaction(CouponTypeID)values(@id)", cnx);<br />                        <br />            insertCmd.Parameters.Add("@Id", SqlDbType.int);<br />            insertCmd.Parameters["@Id"].Value = Convert.ToInt32(ToddlCType.SelectedValue);<br />                   <br />            insertCmd.ExecuteNonQuery();<br />            ErrorMessage.Text = "Records inserted successfully";<br />            cnx.Close();<br />        }<br />        catch (Exception ex)<br />        {<br />            ErrorMessage.Text = ex.Message;<br />        }

You must put a break point and check what results you get from the selected value. it might have returned an empty string that is why you got that error. You must stop assuming the input from the user is correct.

Try it and tell me what it does

PratapBhaskar · Answer 3 · 2010-03-22T22:56:00

Solution 5

Use try parse and check for the value.

Posted 22-Mar-10 22:56pm

PratapBhaskar

**PSK_** · Answer 4 · 2010-03-23T22:18:00

Are you doing something like this

C#

protected void Page_Load(object sender, EventArgs e)
        {
            BindList();
        }

In this case the selected value will be reset as the list gets binded againg before the buttone click event takes place.

Make sure that you bind you list only once, not in each and every postback like following.

C#

protected void Page_Load(object sender, EventArgs e)
      {
          if (!IsPostBack)
          {
              BindList();
          }
      }

navi.s · Answer 5 · 2010-06-03T13:46:00

Solution 7

In the dropdown list give Dropdownlist selected text and selected value.

set ur Dropdownlist Selected Text:CouponTypeText
and selected Value:CouponTypeID

Posted 3-Jun-10 13:46pm

navi.s

navi.s · Answer 6 · 2010-06-03T13:49:00

Solution 8

Have you add DataValueField,DataTextField in your dropdownlist:

XML

<asp:DropDownList ID="DropDownList1" runat="server" DataValueField="CouponTypeID"
         DataTextField="CouponTypeText">
        </asp:DropDownList>

Posted 3-Jun-10 13:49pm

navi.s

**Dalek Dave** · Answer 7 · 2010-10-25T01:15:00

Solution 10

Interesting Question, good answers, shame it is 15 months old.

Why did this get answered here?

Moderators to Red Alert?

Posted 25-Oct-10 1:15am

Dalek Dave

Christian Graus · Answer 8 · 2009-12-26T10:39:00

Solution 3

For the record, it's WRONG to say that tryparse is quicker. It's only quicker if the attempt is not valid, because it does not throw an exception. The reason to use it, is to make sure the input is valid.

Posted 26-Dec-09 10:39am

Christian Graus

am.net · Answer 9 · 2010-03-22T21:39:00

Solution 4

hi,

first correct ur query, you didnt mention the table name in ur query.
"insert into CouponTransaction(CouponTypeID)values(@id)"

Posted 22-Mar-10 21:39pm

am.net

Vigneshb6 · Answer 10 · 2010-10-25T01:11:00

Solution 9

try this one
"insert into CouponTransaction(CouponTypeID)"+"Values(@id)"

Posted 25-Oct-10 1:11am

Vigneshb6