update in database error

Question

0.00/5 (No votes)

See more:

I tried this code for update its not working and its not showing error also while running its just loading but in lable its showing your data is updated.i tried all the exp more that 10 from net.all the samples behaves like the same.plz any one help me.(datakeyname="id,name")

C#

protected void update(object sender, GridViewUpdateEventArgs e)
        {
 
            int id = Convert.ToInt32(GridView1.DataKeys[e.RowIndex].Value.ToString());
            string name = GridView1.DataKeys[e.RowIndex].Values["Name"].ToString();
            TextBox txtAddress1 = (TextBox)GridView1.Rows[e.RowIndex].FindControl("txtAddress1");
            TextBox txtAddress2 = (TextBox)GridView1.Rows[e.RowIndex].FindControl("txtAddress2");
            TextBox txtCountry = (TextBox)GridView1.Rows[e.RowIndex].FindControl("txtCountry");
            TextBox txtPincode = (TextBox)GridView1.Rows[e.RowIndex].FindControl("txtPincode");
            con.Open();
            SqlCommand cmd = new SqlCommand("update tbladminreg set Address1='" + txtAddress1.Text + "',Address2='" + txtAddress2.Text + "',Country='" + txtCountry.Text + "',Pincode='" + txtPincode.Text + "' where id=" + id, con);
            cmd.ExecuteNonQuery();
            con.Close();
            Label1.Text = name + " Details Updated successfully";
            GridView1.EditIndex = -1;
            gridload();
 
                   }

Posted 16-May-12 1:13am

dineshdena

Updated 16-May-12 1:18am

sravani.v

v2

Add a Solution

Comments

Zoltán Zörgő 16-May-12 7:18am

And what's the error message?
Build you statement in a string and try to run it in SQL Management Studio. Make it run without errors, than convert it to code. And use parameters, if you dont want SQLi.

hitech_s 16-May-12 7:26am

can you post the error what you are getting

MAKReddy 16-May-12 7:38am

can u check ur grid view source side datakeys names is correct or not?

dineshdena 16-May-12 7:41am

actually im not getting any error.......while i click update its just loading and i have label in the bottom there its showing ur data is updated....but in database its not get updated........

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-05-16T01:34:00

That is a very nasty way to do things, it introduces so many ways that you could get a problem.
First off:

C#

int id = Convert.ToInt32(GridView1.DataKeys[e.RowIndex].Value.ToString());

Why? Why convert it to a string, in order to convert it back to an int? If the ToString does not return you a numeric value, then the convert will fail and it won't work. If it will return a numeric value, then why are you converting it you a string in the first place?

Secondly: Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead. All it would take to destroy you database is a couple of characters in any address field: easy to enter, deliberately or by accident.

C#

SqlCommand cmd = new SqlCommand("update tbladminreg set Address1=@AD1, Address2=@AD2, Country=@CNT, Pincode=@PNC where id=@ID", con);
cmd.Parameters.AddWithValue("@AD1", txtAddress1.Text);
cmd.Parameters.AddWithValue("@AD2", txtAddress2.text);
...

Fix them, see if it works afterwards.

Code 89 · Answer 2 · 2012-05-16T01:27:00

Try this..

SqlCommand cmd = new SqlCommand("update tbladminreg set Address1='" + txtAddress1.Text.ToString().Trim() + "',Address2='" + txtAddress2.Text.ToString().Trim() + "',Country='" + txtCountry.Text..ToString().Trim() + "',Pincode='" + txtPincode.Text.ToString().Trim() + "' where id=" + id, con);

MAKReddy · Answer 3 · 2012-05-16T01:44:00

Solution 3

C#

int id = Convert.ToInt32(GridView1.DataKeys[e.RowIndex].Values(0)

try this in ur code behend id place

Posted 16-May-12 1:44am

MAKReddy

update in database error

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0