i got error msg say : possible unintended string comparison to get a value comparison, cast the right hand side

Question

0.00/5 (No votes)

See more:

private ArrayList newFiles = new ArrayList();
string filename = "logFile.txt";
int i = 0;

for (i = 0; i < newFiles.Count; i++)
{
if (filename == newFiles[i])
MessageBox.Show("Found " + i);
else
MessageBox.Show("Not Same " + i);
}

i tried to compare a var filename type of string with newFiles type of Arraylist...
it indicated those error..possible unintended string comparison to get a value comparison, cast the right hand side...anyone can help? thanks in advance..

Posted 9-Dec-11 6:47am

beh7606

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

dallyack · Accepted Answer · 2011-12-09T06:51:00

Solution 1

if(filename == newFiles[i].ToString)

or maybe

if(filename == System.Convert.ToString(newFiles[i])

or cast the right hand side i think like this...

if(filename == (string)newFiles[i])

Posted 9-Dec-11 6:51am

dallyack

Comments

beh7606 9-Dec-11 13:10pm

hahaha...thanks dallyck!! i owe u...

phil.o · Accepted Answer · 2011-12-09T09:54:00

Use a List<string> rather than an ArrayList.

The problem here is that an ArrayList can contain everything by nature, not just strings. So here, when you try to compare the value of the list at the current index, compiler is not sure this value is actually a string. Hence the problem.

With a List<string> you would not have this issue.

Otherwise, you are creating an empty list at the beginning of your procedure, and then directly start to iterate over it. Maybe you didn't want to bother us with the init procedure, or maybe you forgot it ?