A c progarm for count digits and white space,

Question

0.00/5 (No votes)

See more:

Hi,

I just put some c code into MS c++ 6.0 to run, but the code is not work.
It can't output the expectation result. anyone can help? thanks:-

C++

#include <stdio.h>

main()
{
    int c, i, nwhite, nother;
    int ndigit [ 10 ];

    nwhite = nother = 0;
    for( i = 0; i<10; ++i)
        ndigit [ i ] = 0;

    while (( c = getchar() ) != EOF)
        if( c >= ' 0 ' && c <= ' 9 ')
            ++ndigit [ c - ' 0 ' ];
        else if ( c == ' ' || c == ' \n ' || c == ' \t ')
            ++nwhite;
        else
            ++nother;

    printf(" digits = ");
    for ( i = 0 ; i <10; ++i )
        printf (" %d ", ndigit[ i ]);

    printf (", white space = %d , other = %d \n", nwhite, nother);
}

[edit]Code block added - OriginalGriff[/edit]

Posted 7-Dec-11 2:42am

Member 8468009

Updated 7-Dec-11 3:10am

OriginalGriff

v3

Add a Solution

Comments

Albert Holguin 7-Dec-11 9:12am

What do you mean it doesn't work? Be more specific, does it not do what you expect? Does it crash? Does it not compile? Does it not link?

Legor 7-Dec-11 9:12am

What exactly isn't working?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2011-12-07T03:12:00

Solution 1

It's because you're looking for ' 0 ' instead of '0'. In other words, remove the padding for everything except the space character.

Posted 7-Dec-11 3:12am

#realJSOP

OriginalGriff · Answer 2 · 2011-12-07T03:28:00

The first thing to note is that you need to get rid of the spurious spaces in your comparison literals.
at the moment, the comparison is against teh whole value "space zero space" rather than "zero".
Try:

C++

int c, i, nwhite, nother;
int ndigit [ 10 ];

nwhite = nother = 0;
for( i = 0; i<10; ++i)
{
    ndigit [ i ] = 0;
}
while (( c = getchar() ) != EOF)
{
    if( c >= '0' && c <= '9')
    {
        ++ndigit [ c - '0' ];
    }
    else if ( c == ' ' || c == '\n' || c == '\t')
        {
            ++nwhite;
    }
    else
    {
        ++nother;
    }
}
printf(" digits = ");
for ( i = 0 ; i <10; ++i )
{
    printf (" %d ", ndigit[ i ]);
}
printf (", white space = %d , other = %d \n", nwhite, nother);
c = getchar();

Note that I have included block start and end around every statement, even when they aren't necessary. It is worth doing this, particularly when you are just starting, as you can easily be confused by indentation into thinking a loop goes further than it actually does:

C++

while (c != EOF)
   printf(".");
   c = getchar();

Looks like it works, but

C++

while (c != EOF)
{
   printf(".");
   c = getchar();
}

Actually does!