error in stored procedure

Question

0.00/5 (No votes)

See more:

i am getting error in this stored procedure.

Msg 102, Level 15, State 1, Procedure insertUser, Line 13
Incorrect syntax near '@Result'.

The query seems ok....
here is the stored procedure

SQL

set ANSI_NULLS ON
set QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[insertUser] 
@UserName varchar(50),
@Password varchar(50),
@FirstName varchar(50),
@LastName varchar(50),
@Email varchar(150),
@Mobile varchar(50),
@Result varchar(100) output
AS
BEGIN
	INSERT INTO users(UserName,Password,FirstName,LastName,Email,MobileNo)VALUES (@UserName,@Password,@FirstName,@LastName,@Email,@Mobile)
	IF((SELECT COUNT(*) FROM users WHERE UserName = @UserName) > 0)
    @Result = 'User already exists'
		ELSE
    @Result = 'User successfully added'
	
END

Posted 27-Nov-11 0:50am

codegeekalpha

Updated 27-Nov-11 15:27pm

Eduard Lu

v2

Add a Solution

Comments

[no name] 27-Nov-11 7:18am

i have already fixed this one. look at my solution on your older post.

[no name] 27-Nov-11 7:20am

i updated my solution right after posting. you didn't get my update. sorry :)

3 solutions

Solution 1

Put SET at required places

SQL

SET @Result = 'User already exists'
    ELSE
SET @Result = 'User successfully added'

Posted 27-Nov-11 1:12am

thatraja

Comments

RaisKazi 27-Nov-11 7:19am

It has a logical mistake also. :) Please have a look at my Answer. (Voted 4 as this should solve syntax error).

Solution 2

Try adding SELECT

SQL

IF((SELECT COUNT(*) FROM users WHERE UserName = @UserName) > 0)
SELECT @Result = 'User already exists'
    ELSE
SELECT @Result = 'User successfully added'

Posted 27-Nov-11 1:16am

OriginalGriff

Comments

RaisKazi 27-Nov-11 7:19am

It has a logical mistake also. :) Please have a look at my Answer. (Voted 4 as this should solve syntax error).

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RaisKazi · Accepted Answer · 2011-11-27T01:17:00

Not only your Stored Procedure has a syntax Errors but it also has a logical mistake. You are inserting a record and then checking if that record is present or not. [Edited - For spelling correction.]

Change your Stored Procedure as below.

SQL

set ANSI_NULLS ON
set QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[insertUser] (
@UserName varchar(50),
@Password varchar(50),
@FirstName varchar(50),
@LastName varchar(50),
@Email varchar(150),
@Mobile varchar(50),
@Result varchar(100) output )
AS
BEGIN

Declare @UserCount int;

SELECT @UserCount = COUNT(*) FROM users WHERE UserName = @UserName;

IF(@UserCount > 0)
begin

 Set  @Result = 'User already exists';

end
ELSE
begin

 INSERT INTO users(UserName,Password,FirstName,LastName,Email,MobileNo)VALUES (@UserName,@Password,@FirstName,@LastName,@Email,@Mobile);


 Set  @Result = 'User successfully added';

end
	
END

error in stored procedure

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us