Parsing to Int doesn't work for some reason.

Question

0.00/5 (No votes)

See more:

Been wasting a lot of time on this. I think it 'should' work, but I can't find what's wrong with it.

C#

protected int Checkscore(Node x)
    {
            string[] numbers = x.GetProperty("answers").Value.Split(';');
            int score = 0;
            foreach (string n in numbers)
            {
          //      score += int.Parse(n);
                LabelMonitor.Text += n + " ";
            }
            
            return score;
    }

The property "answers" looks like this: "1;100;1;50;"
And "LabelMonitor" shows this: "1 100 1 50"

So, it should be okay to parse and count them all up right?
Yet, if I uncomment the other line, it throws an exception:

"Input string was not in a correct format."

Does anyone know what I did wrong? I'm going crazy. :-s

Posted 21-Oct-11 6:18am

0bx

Add a Solution

4 solutions

Solution 2

Have you tried Convert.ToInt32(n). I seem to have more luck with that than with int.Parse, especially when converting results from a database.

Posted 21-Oct-11 6:32am

Wayne Gaylard

Solution 3

I've just tried this with the values you showed and it works correctly. Try stepping through your code with the debugger to see where you get an invalid string.

Posted 21-Oct-11 6:46am

Richard MacCutchan

Comments

André Kraak 21-Oct-11 13:08pm

Did you include the final ';' in the source string?
Because of this the Split returns a final empty string, which when parsed causes the FormatException.

Richard MacCutchan 21-Oct-11 15:16pm

Wow, I managed to miss that, foolishly typing the values into my code rather than using Copy & Paste. But, it's yet another reason why TryParse() is always the better choice.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mehdi Gholam · Accepted Answer · 2011-10-21T06:23:00

Solution 1

Try this :

C#

if(n!="") score += int.Parse(n);

Posted 21-Oct-11 6:23am

Mehdi Gholam

Comments

André Kraak 21-Oct-11 13:09pm

my 5, good catch that the final ';' in the string causes a empty string to be returned by the Split.

Mehdi Gholam 21-Oct-11 13:12pm

Yep that's it, happened to me a couple of times.

André Kraak · Accepted Answer · 2011-10-21T11:29:00

The solution given by Mehdi Gholam works, but this alternative also solves your problem.

C#

protected int Checkscore(Node x)
    {
            char[] delimiter = {';'};
            string[] numbers = x.GetProperty("answers").Value.Split(delimiter, StringSplitOptions.RemoveEmptyEntries);
            int score = 0;
            foreach (string n in numbers)
            {
                score += int.Parse(n);
                LabelMonitor.Text += n + " ";
            }
            
            return score;
    }

The StringSplitOptions.RemoveEmptyEntries[^] option tells the Split[^] function to remove all empty results.

To make sure the code also works when the string contains non digit characters you should use Int32.TryParse[^].
When using TryParse you also deal with the empty result from the Split function, so you can use your original call to the Split function again.

C#

protected int Checkscore(Node x)
    {
            string[] numbers = x.GetProperty("answers").Value.Split(';');
            int score = 0;
            int parseResult = 0;

            foreach (string n in numbers)
            {
		if (Int32.TryParse(n, out parseResult))
                	score += parseResult;
                LabelMonitor.Text += n + " ";
            }
            
            return score;
    }