Can anybody tell me why this code crashes at delete.

Question

3.00/5 (2 votes)

See more:

char *day = new char[2];
char *tempMonth = NULL;
char *tempDay = NULL;
char temp[12];

strcpy_s(temp,sizeof(temp),"12-12");
tempDay = strtok_s(temp,"-",&tempMonth);

strcpy_s(day,sizeof(day),tempDay);

delete[] day;

Posted 16-Jun-11 2:47am

NipunG

Add a Solution

Comments

NipunG 16-Jun-11 8:59am

still this code crashes...

Albert Holguin 16-Jun-11 10:08am

yes there is...

Albert Holguin 16-Jun-11 20:08pm

lol, no prob...

Sergey Alexandrovich Kryukov 16-Jun-11 14:41pm

How come? If you do "new" who will reclaim the memory?
--SA

2 solutions

Solution 2

Remember that strings are zero terminated! You should always reserve one more character for the \0 at the end of the string. In other words - change:

char *day = new char[2];

to:

char *day = new char[3];

That should do it.

BTW I disagree with strogg - IMHO it's always a good idea to pair new[] with delete[] - even if there are no destructors to call.

Posted 16-Jun-11 3:23am

tolw

Comments

Albert Holguin 16-Jun-11 10:10am

I disagree with strogg as well... but think matthew had correct solution

TRK3 16-Jun-11 18:40pm

Actually, Matthew solved the crash, but he's going to want to add a 3rd char to null terminate *day if he's going to use it anywhere. Without that as soon as he tries to use *day he's going to have a problem.

Albert Holguin 16-Jun-11 20:08pm

true

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Matthew Faithfull · Accepted Answer · 2011-06-16T03:21:00

Solution 1

At first glance I woud say misunderstanding sizeof is your problem. sizeof a char* will give you the size of a pointer, i.e. 4 bytes on a 32bit system. Copy 4 bytes into a 2 byte buffer and you're lucky to get as far as the delete[] before it crashes :-)
Check the docs for sizeof.

Posted 16-Jun-11 3:21am

Matthew Faithfull

Comments

NipunG 16-Jun-11 9:23am

Thanks Mathew...problem solved:)

Albert Holguin 16-Jun-11 10:10am

good catch... my 5

Sergey Alexandrovich Kryukov 16-Jun-11 14:39pm

Agree, a 5.
--SA