SQL Zero Returns Wrong Answer

Question

0.00/5 (No votes)

See more:

I know the answer is "0" but it returns the first part of this if statement. It should return the second part "No Access"

mysql_query(conn,"SELECT COUNT(*) FROM tblURL WHERE IP = '192.168.1.199' AND Status = 'Active'");
		my_ulonglong i = 0;
		res_set = mysql_store_result(conn);
		my_ulonglong numrows = mysql_num_rows(res_set);
 
		if (numrows >= 1)
		{
		row = mysql_fetch_row(res_set);
		printf("Access Permited: %s\n",row[i]);
		}
		else if (numrows = 0)
		{
		row = mysql_fetch_row(res_set);
		printf("No Access: %s\n",row[i]);
		}
		
		
		mysql_free_result(res_set);
		mysql_close(conn);
		system("PAUSE");

Posted 12-May-11 7:52am

Member 7766180

Add a Solution

3 solutions

Solution 1

else if (numrows == 0)

Posted 12-May-11 8:18am

uToLs

Comments

OriginalGriff 12-May-11 14:47pm

At first glance I thought you were being facetious, then I noticed what you meant. Good point! It doesn't solve his problem, and it's one reason why I always set "Treat warnings as errors" but it is a very good point. Gets my 5, but it would have been worth your commenting on why that is important!

Albert Holguin 12-May-11 14:53pm

good catch...

Kim Togo 13-May-11 3:54am

Good catch. "numrows" will be assigned the value of "0".
C++ will you allow this. Where C# compiler will hit you with:

"Cannot implicitly convert type 'int' to 'bool'"

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2011-05-12T08:20:00

Solution 2

I think you need to spend more time studying your programming guides and less time posting the same basic question over and over again.

Posted 12-May-11 8:20am

Richard MacCutchan

Comments

Kode King 12-May-11 16:21pm

Perhaps you should spend "No Time" posting opinions on another persons abilities and instead post some "answers". That's the reason this forum is here. Not to tell people to read the manual!

Albert Holguin 12-May-11 16:45pm

i agree... at least this guy is trying, i post mean stuff for people who don't try.

Richard MacCutchan 13-May-11 3:47am

Yes, he's very trying! He has posted basically the same question at least three times now and been given lots of help. And now a simple expression error and he's straight back with another post, rather than using his brain and debugger to find a very basic error.

Albert Holguin 13-May-11 10:09am

well, like others have suggested, you don't HAVE to read his posts or answer, if you chose to do so... your wasting your own time.

Richard MacCutchan 13-May-11 11:01am

Well it obviously bothers you that I'm trying to help him. Maybe you could try to do the same rather than sniping at me.

Albert Holguin 13-May-11 11:24am

I am, I'm sure you've seen my name around ;) ... but I'm also not being mean about everything... everyone needs help sometime, he obviously needs a bit more

Richard MacCutchan 13-May-11 12:58pm

What's mean about offering advice and suggestions?

Albert Holguin 13-May-11 11:26am

Maybe we can all chip in and get him a C++ book for Christmas... just saying... may save someone a colossal breakdown

Richard MacCutchan 13-May-11 3:45am

Where the hell did you come from, you've been a member of this site for one day and think you can pass judgement on something that you know nothing about? I, and others, have answered this question, suggested changes to his code and given general advice, and still he reposts basically the same question showing that he has not taken any notice of the help he has been given, and possibly needs to go back to basics and learn the difference between '=' and '==' in an if statement.

Kode King 13-May-11 11:04am

Please no cursing! You! Answered the question!!!! Obviously not. Yes, I just joined, and you've been around, but does that give you license to be abusive to someone who's just looking for some help! Really, if you answered the question, his code would work, but it doesn't! So perhaps a real answer with some code attached? You do remember how to code?

Richard MacCutchan 13-May-11 11:07am

Dude, you don't know what abuse is. May I suggest you read all the OP's questions on this subject, all the suggestions offered (not just mine) and ask yourself how hard is he trying to solve his own problem.

Kode King 13-May-11 11:30am

Don't call me Dude. Post some answers. Be civil. Don't curse. Post some answers.

Richard MacCutchan 13-May-11 12:57pm

Dude, I've posted answers, suggestions and advice. All you have done is add clutter and noise.

Kode King 13-May-11 13:07pm

Don't call me Dude. You are delusional.

Richard MacCutchan 14-May-11 4:01am

Dude, I never have delusions.

Kode King 13-May-11 13:16pm

Redeem yourself. Post the answer!

Richard MacCutchan 14-May-11 3:58am

Give it a rest Dude.

OriginalGriff · Accepted Answer · 2011-05-12T08:21:00

Solution 3

I am getting serious deja vu here: we have been here before!

SELECT COUNT(*) FROM...

Returns a dataset containing one row. Always.
That row, has one column. Always.
The single cell in the entire dataset contains the number of matching rows in the database.
This could be 0, 1, or any other integral value.
So numrows - being the count of the number of rows returned - will always be one. Always.

So your test

if (numrows >= 1)

will always suceed. Always. Always. Always.

[edit]Added an extra "Always" for good measure. :D[/edit]
[edit]Just for drama, an extra "Always" added[/edit]

Posted 12-May-11 8:21am

OriginalGriff

Updated 12-May-11 23:24pm

v3

Comments

Marc A. Brown 12-May-11 14:40pm

Exactly. Well answered.

Albert Holguin 12-May-11 14:54pm

good answer... and yes, does look familiar...lol

Member 7766180 12-May-11 15:01pm

I've run test and the answer will either be "1" or "0". I've gotten both results. I simply want to add another if statemnet to this, If the result is "1" then "Access Permited" else if it's "0" then "No Access"

Member 7766180 12-May-11 15:28pm

So what in this code is actually returning the "0"? Is it the row = mysql_fetch_row(res_set);
printf("Access Permited: %s\n",row[i]);

If so can I do...
If row[i] = 1 then
printf("Access")
else
printf("No Access")