Please could someone find where the error in my code is, as when I try to run the program an error message is displayed as follows: stopped working and close down

Question

1.00/5 (1 vote)

See more:

C#

#include <stdio.h>
struct subjectRecord
{
    char subjectCode;
    char subjectName;
    char lecturer;
    int creditHour;
}subject[3];
int main(void)
{
    int a;
    for(a = 0; a <3; a++)
    {
        printf("\nEnter Subject Code: ");
        scanf("%s", &subject[a].subjectCode);
        printf("Enter Subject Name: ");
        scanf("%s", &subject[a].subjectName);
        printf("Enter Lecturer Name: ");
        scanf("%s", &subject[a].lecturer);
        printf("Enter Credit Hour: ");
        scanf("%d", &subject[a].creditHour);
    }
    for(a = 0; a <3; a++)
    {
        printf("Subject Code :%s\n",subject[a].subjectCode);
        printf("Subject Name: %d %d%d\n", subject[a].subjectName);
        printf("Lecturer Name:%s\n",subject[a].lecturer);
        printf("Credit Hour:%s\n",subject[a].creditHour);
    }
}

Please could someone find where the error in my code is, as when I try to run the program an error message is displayed as follows: stopped working and close down

Posted 3-May-11 8:35am

Jayfam

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

HimanshuJoshi · Answer 1 · 2011-05-03T08:41:00

Solution 1

Your subjectCode. subjectName and lecturer variables are declared as characters but you are using them as character arrays. Declare them as character arrays instead of just characters.

Posted 3-May-11 8:41am

HimanshuJoshi

Comments

Jayfam 3-May-11 14:47pm

i declared them using struct char already

Ed Nutting 3-May-11 14:54pm

Just seen your new question. If you look at my original solution you will see where your problem lies. Char is one character in a string like 'a' or 'z' or any other letter/number/chrarcter. This means that char subjectName can only hold one character (or in your case letter). What you need in C is to declare a char array which means an array of characters or as you may know it, a string. The code should therefore look like: char *variable name*[*expacted or known length string*] which in your case will probably be char subjectName[100]; That help?

Note: You also haven't changed your formatting in your second for loop. You need to change the %d to %s in subject name print line and %s to %d in the credit hour print line.

Jayfam 3-May-11 14:55pm

ok, i try it out see

Jayfam · Answer 2 · 2011-05-03T09:44:00

C#

#include <stdio.h>
struct subjectRecord
{
    char subjectCode[20];
    char subjectName[50];
    char lecturer[100];
    int creditHour;
}subject[10];
int main(void)
{
    int a;
    for(a = 0; a <10; a++)
    {
        printf("\nEnter Subject Code: ");
        scanf("%s", &subject[a].subjectCode);
        printf("Enter Subject Name: ");
        scanf("%s", &subject[a].subjectName);
        printf("Enter Lecturer Name: ");
        scanf("%s", &subject[a].lecturer);
        printf("Enter Credit Hour: ");
        scanf("%d", &subject[a].creditHour);
    }
    for(a = 0; a <10; a++)
    {
        printf("\nSubject Code :%s\n",subject[a].subjectCode);
        printf("Subject Name: %s\n", subject[a].subjectName);
        printf("Lecturer Name:%s\n",subject[a].lecturer);
        printf("Credit Hour:%d\n",subject[a].creditHour);
    }
}