Winform and an added class question

Question

4.67/5 (3 votes)

See more:

I created code in the Form.cs and I added a class, (the whole thing acts as an MVC model, file executes the logic of the file, the other file illustrates it with WinForm changes. Problem is, as oppose to a console applications, I get mistakes that I don't understand why I get them

I get this mistake:

Error 2 Inconsistent accessibility: parameter type 'WindowsFormsApplication1.Pieces[*,*]' is less accessible than method 'WindowsFormsApplication1.ChessBoard.PrintPieces(WindowsFormsApplication1.Pieces[*,*])' D:\Documents and Settings\Dima\My Documents\Visual Studio 2008\Projects\ChessBoardGame\ChessBoardGame\ChessBoard.cs 1135 21 ChessBoardGame

I used one method in my Form class:

C#

public void PrintPieces(Pieces [,] pieces)
{
}

and in the class2 I call it like this
C# Syntax (Toggle Plain Text)

C#

public static void ExecuteAll(int rowStart,int columnStart,int rowEnd,int columnEnd) {
  Pieces[,] pieces = ChessBoard();
  ChessBoard chessB = new ChessBoard();
  chessB.PrintPieces(ChessBoard());
}

Why is it a mistake?

[EDIT]
Oooh, damn. I changed it now. Now the mistake is gone.
Does it mean that I can use the elements of both codes with no problem. I want the Form.cs to present the data on WinForm and the class that I have added to perform the code

Posted 12-Mar-11 7:37am

Dmitry Makovetskiy

Updated 12-Mar-11 14:29pm

Henry Minute

v4

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-03-12T09:34:00

It is a mistake because your public method has as a parameter a class "Pieces" which is not itself publicly available.

It means that the method can never be called publicly, because it is impossible to supply the required parameter.

Change the definition of your method to match the availability of "Pieces" or make the "Pieces" class public as well.

By the way, I assume from the method parameters that the "Pieces" class represents a single chess piece with each instance. That makes a lot of sense, and is a good thing. However, the name implies that it holds more than one piece. Normally, an instance of a single object would have a singular name, rather than plural, allowing the plural to be used for a collection. I suggest that you change the name to "Piece" or possibly "ChessPiece".

Robert Rohde · Accepted Answer · 2011-03-12T09:27:00

Solution 1

You havea public method but the class Pieces is not. I assume its either private or internal. Make it public and everything should be ok.

Posted 12-Mar-11 9:27am

Robert Rohde

Comments

Sergey Alexandrovich Kryukov 12-Mar-11 18:08pm

Should be internal, not public if possible. Access should be minimal. Public is needed to be accessible from other assemblies or is the base class of overridden member was declared as public in base class.
--SA