C# windows form MDB Operator Problem saving Record

Question

0.00/5 (No votes)

See more:

I am trying to save a record BOOK_NAME value "Mit'in gizli tarihi" in this value it gives error "In operator without () in query expression "Mit'in......('. " while saving record. Because of operator " ' "

But I can save this record from directly mdb file. why I can't save from windows form.

string query = "Insert INTO BOOKS(BOOK_NAME,TYPE,AUTHOR,PUBLISH_YEAR,PUBLISH_COMPANY,INFO) VALUES ('" + txtBookName.Text  + "', '"
                    + comboTypes.Text + "', '" +  txtBookAuthor.Text+ "', '" +txtPunlishYear.Text  + "', '" +txtPublishCo.Text  + "','"+ txtInfo.Text +"' )";

OleDbCommand Command = new OleDbCommand(query, dbConnection);

 if (dbConnection.State.ToString() == "Closed")
                    dbConnection.Open();
Command.ExecuteReader();

dbConnection.Close();

Posted 5-Jan-11 0:13am

Emir Aras

Add a Solution

3 solutions

Solution 3

Thank you guys.

@JOAT-MON

this is a very quick fix.

@Espen Harlinn

Thank you.

I will study about Parameters.

Posted 5-Jan-11 0:59am

Emir Aras

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Espen Harlinn · Accepted Answer · 2011-01-05T00:19:00

Solution 1

Use parameters[^] instead of string concatenation.

Regards
Espen Harlinn

Posted 5-Jan-11 0:19am

Espen Harlinn

JOAT-MON · Accepted Answer · 2011-01-05T00:42:00

The problem is that the BOOK_NAME has an apostrophe (single quote) in it, which is the SQL string delimiter, causing the rest of your insert to be misaligned. To escape the default behavior you need to replace the single quote ' with two single quotes '' on any strings you insert into the database. For example:

"... '" + txtBookName.Text.Replace("'", "''") + "' ..."

However, using parameters as Espen Harlinn recommended, is safer and will do this automatically for you.