Form Validation

Question

0.00/5 (No votes)

See more:

function Validate()
        {
            if(document.getElementById("<%= ddlClient.ClientID %>").value==0)
	         {
		        document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		        document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Select Client! ";		    
		         return false;
	         }
	         if(document.getElementById("<%= txtname.ClientID %>").value=="")
	         {
		        document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		        document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Enter Job Name! ";	
		        document.getElementById("<%= txtname.ClientID %>").focus();  	    
		         return false;
	         }
	         if(document.getElementById("<%= txtqty.ClientID %>").value=="")
	         {
	            if(document.getElementById("<%= txtamount.ClientID %>").value=="")
	            {
		            document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		            document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Enter Quantity! ";		
		            document.getElementById("<%= txtqty.ClientID %>").focus();   
		        }
		         return false;
	         }
	         
	         if(document.getElementById("<%= ddlratetype.ClientID %>").value==0)
	         {
		        document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		        document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Select Rate Type! ";		    
		         return false;
	         }
	         if(document.getElementById("<%= ddlratetype.ClientID %>").value!="Rate Per LOT")
	         {
	            if(document.getElementById("<%= txtrate.ClientID %>").value=="")
	            {
		            document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		            document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Enter Rate! ! ";		    
		            return false;
		        }
	         }
	          
	         if(document.getElementById("<%= txtamount.ClientID %>").value=="")
	         {
		        document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		        document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Enter Amount! ";	
		         document.getElementById("<%= txtamount.ClientID %>").focus(); 	    
		         return false;
	         }
	         if(document.getElementById("<%= txttax.ClientID %>").value=="")
	         {
		        document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		        document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Enter Tax! ";	
		         document.getElementById("<%= txttax.ClientID %>").focus(); 	    
		         return false;
	         }
	           if(document.getElementById("<%= ddltaxtype.ClientID %>").value==0)
	         {
		        document.getElementById("<%=lblErrormsg.ClientID%>").className="error";
		        document.getElementById("<%=lblErrormsg.ClientID%>").innerHTML="Select Tax Type! ";		    
		         return false;
	         }
	         return true;
        }

Posted 2-Jan-11 19:40pm

Rajkumar Chaurasiya

Updated 2-Jan-11 19:51pm

TweakBird

v4

Add a Solution

Comments

T.Saravanann 3-Jan-11 1:43am

Hi what is this...Are you show your code...

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2011-01-02T20:04:00

OK, don't return true or false, return some useful information on validation failure.

For example, return your inner HTML instead or a class combining inner HTML text and className. It will help you to avoid repeated assignment if every "if" block, all those repeated getElementById, etc. The principle is called Don't Repeat Yourself (D.R.Y., http://en.wikipedia.org/wiki/DRY[^]), one of the most basic and important. As a result, your code will be shorter and of much better supportability.

The properties of the elements showing innerHTML with the style className will be assigned only once in some function calling your function Validate.

That's it.