Converting String to int

Question

3.00/5 (1 vote)

See more:

Im frustrated. I thought this would be easier.
I have used this code before....actually I just cut and pasted it into
my new code. However the array sizes is much larger 1000,10000,100000 and reading from a a file that accept random numbers of up to 300,000. Now my code will not work.

This is the piece of code...

<prelang> while ((number = s.ReadLine()) != null)
           {
               array[item] = Convert.ToInt32(number);
               item++;
           }</prelang>

I am getting the error that input was not in correct format. The funny thing is I separated the code into 2 different files and it worked. I cant figure out why this is. These are very large numbers, could that be it?

thanks
:confused:

Posted 25-Nov-10 20:51pm

Tanacia

Add a Solution

Comments

JF2015 26-Nov-10 2:56am

Could you post the part of the file that causes this exception. There must be some strange value that can not be converted to integer.

CPallini 26-Nov-10 3:27am

Why don't you make a better use of the debugger and find what is the offending input?

4 solutions

Solution 3

Hi, write the while statement as
while (!string.IsNullOrEmpty(number = s.ReadLine())) may be better :) BTW

Posted 25-Nov-10 23:23pm

paladin_t

Updated 25-Nov-10 23:25pm

v3

Solution 4

Hi
If you are getting a "not correct format" error, there could be two reasons:

1) There are non-numeric characters in the string you are trying to convert (such as commas or spaces), or
2) as you stated, the number might be too big.

If it's because the number is too big, then consider using the decimal type. It's like an integer, but can store much larger sizes.

Hope that helps

Posted 26-Nov-10 1:36am

KyleCF89

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Avi Farah · Accepted Answer · 2010-11-25T21:06:00

Solution 1

Tanacia,

1 you may use int.Parse(..) or int.TryParse(..) where you have more control.
2 Can you publish the value of number that throws an exception?

Cheers,
Avi

Posted 25-Nov-10 21:06pm

Avi Farah

Updated 26-Nov-10 1:57am

v2

Comments

Dalek Dave 26-Nov-10 3:55am

Exactly what I would have done!

Tanacia 26-Nov-10 14:03pm

Rock on! Thank you so much! It worked.

Manfred Rudolf Bihy · Accepted Answer · 2010-11-25T21:33:00

Solution 2

Try this:

int LineNo = 0;
while ((number = s.ReadLine()) != null)
{
    lineNo++;
    int n = 0;
    bool didConvert = int.TryParse(number, n);
    if(didConvert)
    {
        array[item] = n;
        item++;
    }
    else
        Console.WriteLine("Line {1}: Could not convert {0} to an int!", number, lineNo);
}

Cheers

Manfred

Posted 25-Nov-10 21:33pm

Manfred Rudolf Bihy

Updated 25-Nov-10 21:36pm

v2

Comments

Dalek Dave 26-Nov-10 3:55am

Yep! that's the way.

Tanacia 26-Nov-10 14:03pm

Whew...this took care of the error! Worked like a charm. That was weird I dont get why now it all of a sudden didnt work!