Whats the problem in this code?

Question

1.00/5 (1 vote)

See more:

class Node {
public:
	int value;
	Node* next=NULL;
	

	Node() {
		next = new Node();
		next->next = NULL;
	}
};

What I have tried:

Everytime i make a new object of this class. I get an exception Stack overflow.

Posted 17-Sep-18 5:09am

Member NFOC

Updated 17-Sep-18 5:19am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2018-09-17T05:19:00

Solution 1

Simple: the first thing your Node constructor does is try to construct a new Node instance. Which calls the Node constructor for that object instance, and the constructor tries to create another new Node instance. So the constructor is called for that one, which ... and you run out of stack space.

Solution: Don't create a new Node in the Node constructor!

Posted 17-Sep-18 5:19am

OriginalGriff

Comments

CPallini 17-Sep-18 11:21am

5.

KarstenK 18-Sep-18 7:04am

It is a recursive call of the constructor. :-O