I got an incorrect syntax near ', '.

Question

1.00/5 (1 vote)

See more:

am trying to insert into a table in my database and i get this error of incorrect syntax near ','. below is my code

What I have tried:

<pre>con = New SqlConnection(cs)
            con.Open()
            Dim cb1 As String = "insert into CheckOut_Room(ID,BillNo,CheckInID,BillDate,Notes ) VALUES (" & txtBillID.Text & ",'" & txtBillNo.Text & "'," & txtCheckInID.Text & ",@d2,@d1)"
            cmd = New SqlCommand(cb1)
            cmd.Connection = con
            cmd.Parameters.AddWithValue("@d1", txtNotes.Text)
            cmd.Parameters.AddWithValue("@d2", dtpBillDate.Value)
            cmd.ExecuteReader()
            con.Close()

Posted 2-Sep-18 6:56am

Member 12414126

Updated 2-Sep-18 7:27am

Add a Solution

2 solutions

Solution 1

It is impossible to know what is exactly your query because it depend on the values used to build the query.
Only the debugger can show what is the real query, then we can say what is the problem.

VB

Dim cb1 As String = "insert into CheckOut_Room(ID,BillNo,CheckInID,BillDate,Notes ) VALUES (" & txtBillID.Text & ",'" & txtBillNo.Text & "'," & txtCheckInID.Text & ",@d2,@d1)"

You are happily mixing concatenation and parameters in same query, that is bad.

Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]

Secondary problem, it is impossible to know what is exactly your query because it depend on the values of the parameters.
Only the debugger can show what is the real query.

Posted 2-Sep-18 7:19am

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Bryian Tan · Accepted Answer · 2018-09-02T07:27:00

Why not keep it clean instead of mixing the Parameterized and regular query with string concatenation? stick with Parameterized. This will save you some headache down the road like SQL injection vulnerability and avoid the syntax issue.

Another observation, look like the txtBillID,txtBillNo,txtCheckInID should be integers, you might need to update the code to convert the string into integer before inserting it into the table.

VB

Dim cb1 As String = "insert into CheckOut_Room(ID,BillNo,CheckInID,BillDate,Notes ) VALUES (@d1, @d2, @d3, @d4,@d5)"
        cmd = New SqlCommand(cb1)
        cmd.Connection = con
        cmd.Parameters.AddWithValue("@d1", txtBillID.Text)
        cmd.Parameters.AddWithValue("@d2", txtBillNo.Text)
        cmd.Parameters.AddWithValue("@d3", txtCheckInID.Text)
        cmd.Parameters.AddWithValue("@d4", dtpBillDate.Value)
        cmd.Parameters.AddWithValue("@d5", txtNotes.Text)