Click here to Skip to main content
15,893,190 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
my code fails the tests
Ten towers are given. You need to compare them. exponentiation occurs from right to left a ^ (a ^ (a ^ a)). At the end, print their indexes in ascending order. Here is my code but it is incorrect.
input
10 // number of towers
4 2 2 2 2 2 // 4 The first number in a line is not an element of the tower, it is the //number of elements in it minus one.
1 2 2
1 3 2
1 2 3
3 2 2 2 2
2 2 2 2
1 3 3
3 3 3 3 3
2 4 3 3
2 2 3 4
output
2 4 3 6 7 5 9 10 1 8

What I have tried:

#include <fstream>
#include <algorithm>

#include <stdio.h>
#include <math.h>
using namespace std;

class tower_t {
public:
    int num; // the tower room
    int height; // the height of the tower
    double val[11]; // content
    double cache[11]; // cache to speed up the calculation

    // Designer
    tower_t() {
        for (int i = 0; i < 11; i++) {
            val[i] = 1;
            cache[i] = 0;
        }
        height = 0;
    }

    // Triple logarithm of the top 3 levels
    double head(int level) {
        if(cache[level] == 0) cache[level] = log10(log10(val[level])) + log10(val[level + 1]) * val[level + 2];
        return cache[level];
    }

    // The calculation of the tops until intermeddle in double
    void normalize() {
        while(height > 1 && (log10(val[height - 2]) * val[height - 1]) < 50) {
            val[height - 2] = pow(val[height - 2], val[height - 1]);
            val[height - 1] = 1;
            height--;
        }
    }

    // Output for debugging
    void print() {
#ifdef _DEBUG
        printf("%2d: {", num);
        for (int i = 0; i < height; i++) {
            if (i > 0) printf(", ");
            if(val[i] < 1000000000) {
                printf("%0.0f", val[i]);
            } else {
                printf("%0.3e", val[i]);
            }
        }
        printf("}\n");
#endif
    }
};

// comparison of two towers
bool compare(tower_t& t1, tower_t& t2) {
    // floor with which to compare the last three levels
    int level = ((t1.height > t2.height) ? t1.height : t2.height) - 3;
    if (level < 0) level = 0;
    if(t1.height == t2.height) { // if the towers are of the same height, compare by floor
        for (int i = t1.height - 1; i >= 0; i--) {
            if (abs(t1.val[i] - t2.val[i]) > (t1.val[i] * 1e-14)) {
                if (i < level) { // the tops of the towers coincided below level
                    return t1.val[i] < t2.val[i];
                }
                break;
            }
        }
    }
    return t1.head(level) < t2.head(level);
}

int main(int argc, char**argv)
{
    // Reading job
    ifstream in ("input.txt");
    int cnt;
    in >> cnt;
    tower_t* towers = new tower_t[cnt];
    for (int i = 0; i < cnt; i++) {
        int len;
        in >> len;
        towers[i].num = i + 1;
        bool write = true;
        for (int j = 0; j <= len; j++) {
            int val;
            in >> val;
            if (val <= 1) write = false; // if level of <= 1 the higher not to read
            if(write) {
                towers[i].val[j] = val;
                towers[i].height = j + 1;
            }
        }
        towers[i].print();
        towers[i].normalize();
    }
    // Sort
    sort(towers, towers + cnt, compare);
    // The output
    ofstream out("output.txt");
    for (int i = 0; i < cnt; i++) {
        out << towers[i].num << " ";
        towers[i].print();
    }
    out << endl;
    out.close();
    delete[] towers;
    return 0;
}
Posted
Updated 15-Jun-18 2:23am

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Comments
Maciej Los 15-Jun-18 2:16am    
5ed!
Member 13855861 15-Jun-18 8:43am    
here is my task https://petr-mitrichev.blogspot.com/2012/05/world-finals-day-2-upe-dinner.html
Your job is also to debug your code.
Quote:
Here is my code but it is incorrect

Your code is not monolithic, it is a set of steps, with simple changes, you can check the intermediate results. Doing this, you will know where things do wrong.
-----
By the way, you gave an output, you forgot to say if it is actual output or expected output, and since you didn't gave the other output we don't know in what it is wrong.
Actual output is ...
Expected output is : ...
-----
Your code do not behave the way you expect, and you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.
Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]
The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

[Update]
Your example in Solution 3 is weird.
23 
9 2 2 2 2 2 2 99 2 9 19 
9 99 99 99 99 99 99 98 2 9 19 
8 25 34 99 75 2 99 99 92 99 
7 99 99 78 98 99 90 99 99 
5 98 99 99 8 2 34 
5 99 99 99 2 2 35 
5 98 99 99 16 2 33 
4 2 2 4 5 4 
3 98 99 98 98 
4 4 4 4 4 4 
3 3 3 3 3 
4 2 2 2 2 2 
3 64 2 2 2 
3 2 3 2 2 
2 4 3 3 
3 2 2 2 2 
1 3 3 
2 2 2 2 
1 3 2 
1 2 3 
0 7 
0 5 
1 2 2 

// correct answer 
23 22 21 20 19 18 17 16 15 14 13 12 11 10 9 8 7 6 5 4 3 2 1 

//my answer 
23 22 21 20 19 18 17 16 15 14 13 12 11 10 9 8 7 6 5 4 3 1 2

// I would have expected
21 22 17 19 20 23 ...

because
0 ^ x is 0 and 1 ^ x is 1
 
Share this answer
 
v4
my code does not pass this test correctly.
input
23 
9 2 2 2 2 2 2 99 2 9 19 
9 99 99 99 99 99 99 98 2 9 19 
8 25 34 99 75 2 99 99 92 99 
7 99 99 78 98 99 90 99 99 
5 98 99 99 8 2 34 
5 99 99 99 2 2 35 
5 98 99 99 16 2 33 
4 2 2 4 5 4 
3 98 99 98 98 
4 4 4 4 4 4 
3 3 3 3 3 
4 2 2 2 2 2 
3 64 2 2 2 
3 2 3 2 2 
2 4 3 3 
3 2 2 2 2 
1 3 3 
2 2 2 2 
1 3 2 
1 2 3 
0 7 
0 5 
1 2 2 

// correct answer 
23 22 21 20 19 18 17 16 15 14 13 12 11 10 9 8 7 6 5 4 3 2 1 

//my answer 
23 22 21 20 19 18 17 16 15 14 13 12 11 10 9 8 7 6 5 4 3 1 2
 
Share this answer
 
v3
Comments
Patrice T 15-Jun-18 8:42am    
Use Improve question to update your question.
So that everyone can pay attention to this information.
By accepting this solution, you say to everyone that the problem is solved.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900