I am getting wrong output in my calculator program in Python

Question

0.00/5 (No votes)

See more:

hey i made a basic calculator program but i am not getting correct output from it this is my code

Python

def add(first,second):
    return  first+second

def multiply(first,second):
    return  first*second

def subtract(first,second):
    return  first-second

def divide(first,second):
    return  first/second

print("1.division")
print('2.multiplication')
print('3.subraction')
print('4.addition')

user_input = input('enter your choice:')
first_num = float(input('enter first number:'))
second_num = float(input('enter another number:'))

if user_input==1:
    print(divide(first_num,second_num))

elif user_input==2:
    print(multiply(first_num,second_num))

elif user_input==3:
    print(subtract(first_num,second_num))
else:
    print(add(first_num,second_num))

the output i am getting is like this

1.division
2.multiplication
3.subraction
4.addition
enter your choice:2
enter first number:8
enter another number:5
13.0
Can Someone help please?

What I have tried:

I tried using different numbers

Posted 4-Jun-18 19:38pm

Member 13858794

Updated 4-Jun-18 22:06pm

Richard MacCutchan

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

V. · Answer 1 · 2018-06-04T20:00:00

Solution 1

Your input choice is not a number, but a string. It will therefore directly go to the else statement. (addition)

Hope this helps.

Posted 4-Jun-18 20:00pm

V.

Patrice T · Answer 2 · 2018-06-04T22:07:00

Change your code to:

PHP

if user_input==1:
    print(divide(first_num,second_num))

elif user_input==2:
    print(multiply(first_num,second_num))

elif user_input==3:
    print(subtract(first_num,second_num))

elif user_input==4:
    print(add(first_num,second_num))

else:
    print(add('Error: wrong choice'))

This way, you don't get wrong result, you are told that the user choice was not recognized.

Quote:
I tried using different numbers

As for the problem in code, solution 1 give you the reason.
All input is a string, so you need to convert to integer or compare with string.