C++: how do I get the re-roll to display a new set of random numbers in dice game?

Question

0.00/5 (No votes)

See more:

I am almost finished with this program, other than I cannot figure out how to get a new set of random numbers when the user chooses to re-roll (rolling R when prompted the first time). Below is my code -- can anyone help me find out where I went wrong with syntax, seed, etc...?

What I have tried:

/*
Program Name: P30DiceIfElseLoopRandom.cpp
Name: Amy Kaskowitz
Date Started: 5/24/2018 ; Date completed:
Program Description:
Write a Dice Game program that would result in output like this:

Beat the computer!

You rolled a 2 and a 1 (total =  3)

Do you want to keep those? (y or n)

n

Rolling again....

You rolled a 4 and a 1 (total =  5)

Do you want to keep those? (y or n)

n

Rolling again....

You rolled a 1 and a 1 (total =  2)

Do you want to keep those? (y or n)

y

The computer rolled 6 and 3 (total = 9)

So sorry. You lose.

===

Hint: use random numbers b/w 1-6, make 4 random numbers
*/

#include <stdlib.h> /// need this for srand() -- for random numbers
#include <time.h> /// need this for time() -- time
#include <iostream>  /// need this for cout<< and cin>>
using namespace std; /// need this for cout<< and cin>>

int main()
{
    int iseed = (int)time(0);
    srand(iseed);

    cout << "Beat the computer! \n";

    int roll1 = 1+rand()%6; /// make a random number for die # 1 for user
    int roll2 = 1+rand()%6; /// make a random number for die # 2 for user
    int UserRoll = roll1 + roll2; /// totals the sum of die 1 and die 2 for the user
    char keep;

    do
    {
    cout << "You rolled a " << roll1 << " and a " << roll2 << " for a total of: " << UserRoll << "\n";
    cout << "\n";

        do
        {
        cout << "Would you like to keep this total, or roll again? \n";
        cout << "\n";
        cout << "Enter \"K\" for keep and \"R\" for roll again: \n";
        cin >> keep;

            if (keep != 'K' && keep != 'R')

            {
                cout << "That is not a valid choice. Please choose Y to keep your total or N to roll again. " << endl;
                cout << "\n";
            }

            } while(keep != 'K' && keep != 'R');



            if (keep == 'R')
            {
                cout << "You chose R--let's roll again. \n";
            }


            else
            {
            cout << "Great! Your total is " << UserRoll << "\n";
            }
        } while (keep == 'R');

    int roll3 = 1+rand()%6; /// make a random number for die # 1 for computer
    int roll4 = 1+rand()%6; /// make a random number for die # 2 for computer
    int ComputerRoll = roll3 + roll4; /// totals the sum of die 1 and die 2 for the computer


    cout << "The computer rolled a " << roll3 << " and a " << roll4 << " for a total of: " << ComputerRoll << "\n";
    cout << "\n";

    if (ComputerRoll < UserRoll)
    {
        cout << "Congratulations! You won! \n";
    }

    if (ComputerRoll > UserRoll)
    {
        cout << "Sorry. You lose. \n";
    }

    if (ComputerRoll == UserRoll)
    {
        cout << "It's a tie. \n";
    }

return 0;
}

/*
SAMPLE RUNS:
------------
Beat the computer!
You rolled a 4 and a 6 for a total of: 10

Would you like to keep this total, or roll again?

Enter "K" for keep and "R" for roll again:
R
You chose R--let's roll again.
You rolled a 4 and a 6 for a total of: 10

Would you like to keep this total, or roll again?

Enter "K" for keep and "R" for roll again:
K
Great! Your total is 10
The computer rolled a 4 and a 6 for a total of: 10

It's a tie.

Process returned 0 (0x0)   execution time : 8.763 s
Press any key to continue.

*/

Posted 26-May-18 16:25pm

Member 13843522

Updated 27-May-18 9:28am

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2018-05-26T19:14:00

Quote:
I am almost finished with this program, other than I cannot figure out how to get a new set of random numbers when the user chooses to re-roll (rolling R when prompted the first time)

You need to workout the logic, a simple method is take output and note what is going on behind the hood.

C++

say game greetings
// Beat the computer!
roll user dices
say user score
// You rolled a 2 and a 1 (total =  3)
say want to keep ?
// Do you want to keep those? (y or n)
get answer
// n
say roll again
// Rolling again....
roll user dices
say user score
// You rolled a 4 and a 1 (total =  5)
say want to keep ?
// Do you want to keep those? (y or n)
get answer
// n
say roll again
// Rolling again....
roll user dices
say user score
// You rolled a 1 and a 1 (total =  2)
say want to keep ?
// Do you want to keep those? (y or n)
get answer
// y
roll computer dices
say computer score
// The computer rolled 6 and 3 (total = 9)
say winner
// So sorry. You lose.

Now, analyze it and device out what is going into the lop and what is not.
This is the structure of your program. Anything different in your code is a structure mistake.
A good reading from famous authors: Structured Programming.pdf[^]

Richard MacCutchan · Answer 2 · 2018-05-27T01:21:00

Create a function that does the rolling, and allow it to accept a parameter which tells it whether to seed the randomiser or not:

C++

int DiceRoll(bool seed = false)
{
    if (seed)
    {
        // seed the randomiser
        srand((int)time(0));
    }

    int roll = 1+rand()%6; // get a random number between 1 and 6

    return roll;
}

// ... in your main loop
    int roll1 = DiceRoll(true);
    while (doing some actions)
    {
        int roll2 = DiceRoll();
        // more code
    }
// ...

CPallini · Answer 3 · 2018-05-27T09:30:00

Try

C++

#include <cstdlib> /// need this for srand() -- for random numbers
#include <ctime> /// need this for time() -- time
#include <iostream>  /// need this for cout<< and cin>>
using namespace std; /// need this for cout<< and cin>>

int main()
{
    srand(time(0));
    cout << "Beat the computer! \n";
    char playAgain;

    do
    {
      int roll1;
      int roll2;
      int UserRoll;
      char keep;
      do
      {
        roll1 = 1+rand()%6; /// make a random number for die # 1 for user
        roll2 = 1+rand()%6; /// make a random number for die # 2 for user
        UserRoll = roll1 + roll2; /// totals the sum of die 1 and die 2 for the user
        cout << "You rolled a " << roll1 << " and a " << roll2 << " for a total of: " << UserRoll << "\n\n";
        cout << "Would you like to keep this total, or roll again? \n";
        cout << "\n";
        while (true)
        {
          cout << "Enter \"K\" for keep and \"R\" for roll again: \n";
          cin >> keep;

          if (keep == 'K' || keep == 'R') break; // exit the loop

          cout << "That is not a valid choice. Please choose Y to keep your total or N to roll again.\n\n";
        }

        if (keep == 'R')
          cout << "You chose R--let's roll again. \n";
         else
           cout << "Great! Your total is " << UserRoll << "\n";
       } while (keep == 'R');

      int roll3 = 1+rand()%6; /// make a random number for die # 1 for computer
      int roll4 = 1+rand()%6; /// make a random number for die # 2 for computer
      int ComputerRoll = roll3 + roll4; /// totals the sum of die 1 and die 2 for the computer

      cout << "The computer rolled a " << roll3 << " and a " << roll4 << " for a total of: " << ComputerRoll << "\n\n";

      if (ComputerRoll < UserRoll)
        cout << "Congratulations! You won! \n";
      else if (ComputerRoll > UserRoll)
        cout << "Sorry. You lose. \n";
      else //if (ComputerRoll == UserRoll)
        cout << "It's a tie. \n";

      cout << "Enter \"Y\" to play again, any other value to quit.\n";
      cin >> playAgain;
    } while (playAgain =='Y');
}

C++: how do I get the re-roll to display a new set of random numbers in dice game?

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0