How do I get value from switch case in javascript

Question

0.00/5 (No votes)

See more:

i have a switch with multiple cases and getting the result as given in below code ,is there a shorter way or a better way for this

What I have tried:

var selectedCase=false;
             var selectedItem='';
            var item = ui.item;
              switch(item.type)
           {
               case 'brands':
               selectedCase=true;
               selectedItem= base_url+'brand/'+item.BrandUniqueName;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'brand/'+item.BrandUniqueName;

               break;
               case 'categories':
               selectedCase=true;
               selectedItem= base_url+'categories/'+item.CategoryUniquename;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'categories/'+item.CategoryUniquename;

               break;
               case "categoryBrand":
               selectedCase=true;
               selectedItem= base_url+'brand/'+item.BrandUniqueName+'?category='+item.CategoryUniquename;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'brand/'+item.BrandUniqueName+'?category='+item.CategoryUniquename;

               break;
               case 'offercategory':
               selectedCase=true;
               selectedItem=  base_url+'offercategory/'+item.OfferCategory;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'offercategory/'+item.OfferCategory;

               break;
               case 'vendorOfferCategory':
               selectedCase=true;
               selectedItem=base_url+'offers/'+item.UniqueName+'?category='+item.OfferCategory;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'offers/'+item.UniqueName+'?category='+item.OfferCategory;

               break;
               case 'vendor':
               selectedCase=true;
               selectedItem= base_url+'offers/'+item.VendorUniqueName;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'offers/'+item.VendorUniqueName;

               break;
               case 'offers':
               selectedCase=true;
               selectedItem= base_url+'offers/'+item.UniqueName;
               searchHeader.saveResult(selectedItem);
                window.location.href = base_url+'offers/'+item.UniqueName;

               break;
               case 'vendorcategory':
               selectedCase=true;
               selectedItem= base_url+'topcategories/'+item.UniqueName;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'topcategories/'+item.UniqueName;

               break;
               case 'vendors':
               selectedCase=true;
               selectedItem= base_url+'offers/'+item.UniqueName;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'offers/'+item.UniqueName;

               break;
               case 'products':
               selectedCase=true;
               selectedItem= base_url+'products/'+item.InternalLink;
               searchHeader.saveResult(selectedItem);
               window.location.href = base_url+'products/'+item.InternalLink;

               break;
               case "Not Available":
               //$("#autocomplete").val('');
               break;

           }

Posted 23-May-18 18:53pm

Member 13841915

Updated 24-May-18 3:14am

Add a Solution

Comments

itsmypassion 24-May-18 1:33am

you can use arrays or object literals instead

https://stackoverflow.com/questions/2307157/alternative-to-the-switch-statement
https://toddmotto.com/deprecating-the-switch-statement-for-object-literals/

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

W∴ Balboos, *GHB* · Answer 1 · 2018-05-24T03:15:00

You can reorganize your data so that you set a value prior to the switch and only modify it when necessary (and possible).

Eg:

selectedCase=true;

You can put that outside the switch and only modify it in the switch when

selectedCase=false;

Remove anything in your switch (loop, whatever) that either remains unchanged, as well. Tell the computer just once!